Ignore tx type 126 for celo #14875
Merged
Ignore tx type 126 for celo #14875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prashantkumar1982
previously approved these changes
Oct 21, 2024
amit-momin
reviewed
Oct 21, 2024
amit-momin
reviewed
Oct 21, 2024
Co-authored-by: amit-momin <[email protected]>
amit-momin
previously approved these changes
Oct 21, 2024
AER Report: CI Core ran successfully ✅AER Report: Operator UI CI ran successfully ✅ |
prashantkumar1982
previously approved these changes
Oct 22, 2024
george-dorin
previously approved these changes
Oct 22, 2024
finleydecker
dismissed stale reviews from george-dorin, prashantkumar1982, and amit-momin
via
a0b0ed8
george-dorin
previously approved these changes
Oct 22, 2024
jmank88
reviewed
Oct 22, 2024
amit-momin
reviewed
Oct 22, 2024
|
george-dorin
approved these changes
Oct 23, 2024
simsonraj
approved these changes
Oct 23, 2024
amit-momin
approved these changes
Oct 23, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
KMontag42
pushed a commit
that referenced
this pull request
Oct 24, 2024
* ignore tx type 126 for celo * add changeset * Update .changeset/few-sloths-explain.md Co-authored-by: amit-momin <[email protected]> * added 0x7e to tx type tests for celo * fix linting issues * update celo bhe test * update celo bhe test * remove uncessary booleans in BHE celo test * change 0x7e tx to switch statement * linting * add default case * ignore 0x7e for celo --------- Co-authored-by: amit-momin <[email protected]>
This was referenced Oct 21, 2024
This was referenced Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that Celo is an OP chain, we need to ignore tx type 126 (0x7e).
The Celo chaintype is still useful because we still need to ignore tx types 123 (0x7b) and 124 (0x7c) on Celo specifically which we already have code for.