support multiple chain evm connection for TXM gas estimator allowing L1 oracle fee fetching #14781

huangzhen1997 · 2024-10-15T21:03:34Z

Description

CCIP wants to implement heuristic-based l1 oracles, that has access to ethClient for a number of chains in addition to the target chain that the TXM is currently pointing at. This PR allows toml config to nodes config for multiple chains, and a map with lazy initialization will be passed down to txm gas estimator, which will be referenced by L1 Oracle component.

A new flag is added to [EVM.GasEstimator.DAOracle] called L1ChainID, by default it's "0" indicating the L1 oracle client is disabled.

Reference:

https://smartcontract-it.atlassian.net/browse/BCFR-911

…r for l1 oracle

github-actions · 2024-10-15T21:05:24Z

Below is an analysis created by an LLM. Be mindful of hallucinations and verify accuracy.

WF: CI Core#a5a57f5

1. HTTP 503 Service Temporarily Unavailable error during push request:[Flakey Test Detection]

Source of Error:

Flakey Test Detection	Re-run tests	2024-10-15T22:50:59.0741381Z 2024/10/15 22:50:59 Error re-running flakey tests: push request failed: status=503, body=<html>
Flakey Test Detection	Re-run tests	2024-10-15T22:50:59.0743612Z <head><title>503 Service Temporarily Unavailable</title></head>
Flakey Test Detection	Re-run tests	2024-10-15T22:50:59.0744832Z <body>
Flakey Test Detection	Re-run tests	2024-10-15T22:50:59.0745887Z <center><h1>503 Service Temporarily Unavailable</h1></center>
Flakey Test Detection	Re-run tests	2024-10-15T22:50:59.0746732Z <hr><center>nginx</center>
Flakey Test Detection	Re-run tests	2024-10-15T22:50:59.0747080Z </body>
Flakey Test Detection	Re-run tests	2024-10-15T22:50:59.0747317Z </html>
Flakey Test Detection	Re-run tests	2024-10-15T22:50:59.0769430Z ##[error]Process completed with exit code 1.

Why: The error occurred because the server handling the push request was temporarily unavailable, likely due to maintenance or overload, indicated by the HTTP 503 status code.

Suggested fix: Retry the request after a brief wait or during off-peak hours. Implement retry logic with exponential backoff to handle such temporary issues automatically.

dimriou · 2024-10-16T10:42:30Z

core/chains/evm/gas/models.go

@@ -54,7 +55,7 @@ type feeEstimatorClient interface {
 }

 // NewEstimator returns the estimator for a given config
-func NewEstimator(lggr logger.Logger, ethClient feeEstimatorClient, chaintype chaintype.ChainType, geCfg evmconfig.GasEstimator) (EvmFeeEstimator, error) {
+func NewEstimator(lggr logger.Logger, ethClient feeEstimatorClient, chaintype chaintype.ChainType, geCfg evmconfig.GasEstimator, getChainClientByID func(id string) (evmclient.Client, error)) (EvmFeeEstimator, error) {


Why pass a function instead of the actual map?

I feel that returning the evmclient.Client interface creates a huge dependency on the estimator's side. Don't we already know the method we will use from the Client? Can't we declare a much smaller interface in its place?

github-actions · 2024-10-16T15:28:35Z

AER Report: CI Core ran successfully ✅

aer_workflow , commit

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

core/services/relay/evm/relayer_extender.go

core/chains/evm/gas/rollups/l1_oracle.go

jmank88 · 2024-10-16T19:41:25Z

core/services/relay/evm/relayer_extender.go

 		if err2 != nil {
 			err = multierr.Combine(err, fmt.Errorf("failed to create chain %s: %w", cid, err2))
 			continue
 		}

+		chainIDToClientMap[cid] = chain.Client()


This is fine for now, but for LOOPP support we will have to pass relayers instead of local clients. Just something to keep in mind.

We won't be able to support the ethereum.FeeHistory type there, for example, but we can sort that out later since it looks like a simple/generic type anyways.

what's LOOPP support ?

LOOP Plugins. The chain-agnostic "relayer" API that sits in front of each chain family implementation. We'll have to update this for the EVM LOOP Plugin.

https://pkg.go.dev/github.com/smartcontractkit/[email protected]/pkg/types#Relayer

core/chains/evm/gas/rollups/l1_oracle.go

cl-sonarqube-production · 2024-10-30T22:50:00Z

Quality Gate passed

Issues
2 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

core/chains/evm/config/toml/config.go

ogtownsend · 2024-10-31T19:55:55Z

core/chains/evm/gas/rollups/l1_oracle.go

 	if daOracle != nil {
+		if clientsByChainID == nil {
+			lggr.Debugf("clientsByChainID map is missing")


makramkd

core/capabilities/ccip changes seem good

…L1 oracle fee fetching (#14781) * add lazy initialization to evm client map and pass it to gas estimator for l1 oracle * remove unrelated * rename and fix lint * add changeset * modify err msg * address comments * go import lint * address comments * add default value of L1ChainID for the DAOracle config * fix doc * update config * fix testdata * update * fix make * update doc * update * fix test * update changeset * update changeset * address comments * rename, need to fix test * fix test, part 1 * rebuild doc * fix test * fix test * update comment * update types to use pointers * fix test * fix * fix test * fix make * fix make * fix make * fix test * refactor function name * address comments * update msg * update test helper * fix test * rename and remove fallback * update changeset * update docs * remove unused

huangzhen1997 added 2 commits October 15, 2024 15:51

add lazy initialization to evm client map and pass it to gas estimato…

e79b6c7

…r for l1 oracle

remove unrelated

c22d4da

huangzhen1997 added 3 commits October 15, 2024 16:34

rename and fix lint

e44d132

add changeset

a85b563

modify err msg

a5a57f5

dimriou reviewed Oct 16, 2024

View reviewed changes

huangzhen1997 added 2 commits October 16, 2024 10:56

address comments

571d77e

go import lint

868c10d

huangzhen1997 marked this pull request as ready for review October 16, 2024 17:35

huangzhen1997 requested review from a team as code owners October 16, 2024 17:35

huangzhen1997 requested review from winder, rstout, asoliman92, makramkd, dimkouv, mateusz-sekara, 0xnogo, jmank88 and dimriou October 16, 2024 17:35

ogtownsend reviewed Oct 16, 2024

View reviewed changes

core/services/relay/evm/relayer_extender.go Outdated Show resolved Hide resolved

core/services/relay/evm/relayer_extender.go Show resolved Hide resolved

jmank88 reviewed Oct 16, 2024

View reviewed changes

core/chains/evm/gas/rollups/l1_oracle.go Outdated Show resolved Hide resolved

jmank88 reviewed Oct 16, 2024

View reviewed changes

core/chains/evm/gas/rollups/l1_oracle.go Outdated Show resolved Hide resolved

jmank88 reviewed Oct 16, 2024

View reviewed changes

address comments

9453007

huangzhen1997 requested review from jmank88 and ogtownsend October 16, 2024 22:19

update docs

8eec016

amit-momin reviewed Oct 30, 2024

View reviewed changes

core/chains/evm/gas/rollups/l1_oracle.go Outdated Show resolved Hide resolved

resolve merge conflicts

200f620

huangzhen1997 requested a review from a team as a code owner October 30, 2024 22:29

remove unused

2408b5a

huangzhen1997 requested a review from amit-momin October 31, 2024 01:56

amit-momin reviewed Oct 31, 2024

View reviewed changes

core/chains/evm/config/toml/config.go Show resolved Hide resolved

amit-momin approved these changes Oct 31, 2024

View reviewed changes

ogtownsend reviewed Oct 31, 2024

View reviewed changes

ogtownsend approved these changes Oct 31, 2024

View reviewed changes

jmank88 approved these changes Nov 1, 2024

View reviewed changes

makramkd approved these changes Nov 4, 2024

View reviewed changes

dimriou added this pull request to the merge queue Nov 4, 2024

mateusz-sekara approved these changes Nov 4, 2024

View reviewed changes

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 4, 2024

dimriou added this pull request to the merge queue Nov 4, 2024

Merged via the queue into develop with commit bfd9a3f Nov 4, 2024
160 checks passed

dimriou deleted the BCFR-911/add-L1-eth-client-support-for-gas-estimator branch November 4, 2024 17:38

github-actions bot mentioned this pull request Nov 4, 2024

[DO NOT MERGE] Changeset Release Preview - v2.20.0 #13148

Draft

This was referenced Nov 20, 2024

[DO NOT MERGE] Changeset Release Preview - v2.19.0 Emirhan-Cavusoglu-sftw/chainlink#1

Draft

[DO NOT MERGE] Changeset Release Preview - v2.19.0 galactic-beyond/chainlink#1

Draft

github-actions bot mentioned this pull request Dec 18, 2024

[DO NOT MERGE] Changeset Release Preview - v2.19.0 petermetz/chainlink#1

Draft

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

support multiple chain evm connection for TXM gas estimator allowing L1 oracle fee fetching #14781

support multiple chain evm connection for TXM gas estimator allowing L1 oracle fee fetching #14781

huangzhen1997 commented Oct 15, 2024 •

edited

Loading

github-actions bot commented Oct 15, 2024 •

edited

Loading

dimriou Oct 16, 2024

dimriou Oct 16, 2024

github-actions bot commented Oct 16, 2024 •

edited

Loading

jmank88 Oct 16, 2024

jmank88 Oct 16, 2024

huangzhen1997 Oct 16, 2024

jmank88 Oct 16, 2024 •

edited

Loading

cl-sonarqube-production bot commented Oct 30, 2024

ogtownsend Oct 31, 2024

makramkd left a comment

support multiple chain evm connection for TXM gas estimator allowing L1 oracle fee fetching #14781

support multiple chain evm connection for TXM gas estimator allowing L1 oracle fee fetching #14781

Conversation

huangzhen1997 commented Oct 15, 2024 • edited Loading

Description

Reference:

github-actions bot commented Oct 15, 2024 • edited Loading

WF: CI Core#a5a57f5

1. HTTP 503 Service Temporarily Unavailable error during push request:[Flakey Test Detection]

dimriou Oct 16, 2024

Choose a reason for hiding this comment

dimriou Oct 16, 2024

Choose a reason for hiding this comment

github-actions bot commented Oct 16, 2024 • edited Loading

AER Report: CI Core ran successfully ✅

AER Report: Operator UI CI ran successfully ✅

jmank88 Oct 16, 2024

Choose a reason for hiding this comment

jmank88 Oct 16, 2024

Choose a reason for hiding this comment

huangzhen1997 Oct 16, 2024

Choose a reason for hiding this comment

jmank88 Oct 16, 2024 • edited Loading

Choose a reason for hiding this comment

cl-sonarqube-production bot commented Oct 30, 2024

Quality Gate passed

ogtownsend Oct 31, 2024

Choose a reason for hiding this comment

makramkd left a comment

Choose a reason for hiding this comment

huangzhen1997 commented Oct 15, 2024 •

edited

Loading

github-actions bot commented Oct 15, 2024 •

edited

Loading

github-actions bot commented Oct 16, 2024 •

edited

Loading

jmank88 Oct 16, 2024 •

edited

Loading