Blue/green deployments for LLO; code cleanup #14628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Static analysis results are availableHey @samsondav, you can view Slither reports in the job summary here or download them as artifact here. Please check them before merging and make sure you have addressed all issues. |
samsondav
force-pushed
the
MERC-5954
branch
5 times, most recently
from
2c66e30 to
551eadf
Compare
samsondav
force-pushed
the
MERC-5954
branch
2 times, most recently
from
58d8f5d to
1606042
Compare
contracts/src/v0.8/llo-feeds/v0.5.0/configuration/Configurator.sol
Outdated
Show resolved
Hide resolved
contracts/src/v0.8/llo-feeds/v0.5.0/configuration/Configurator.sol
Outdated
Show resolved
Hide resolved
contracts/src/v0.8/llo-feeds/v0.5.0/configuration/Configurator.sol
Outdated
Show resolved
Hide resolved
samsondav
force-pushed
the
MERC-5954
branch
6 times, most recently
from
e7262f8 to
1e911a3
Compare
AER Report: CI Core ran successfully ✅AER Report: Operator UI CI ran successfully ✅ |
samsondav
force-pushed
the
MERC-5954
branch
2 times, most recently
from
448ff64 to
89c5e06
Compare
Fletch153
reviewed
Oct 16, 2024
contracts/src/v0.8/llo-feeds/v0.5.0/configuration/Configurator.sol
Outdated
Show resolved
Hide resolved
contracts/src/v0.8/llo-feeds/v0.5.0/configuration/Configurator.sol
Outdated
Show resolved
Hide resolved
jmank88
reviewed
Oct 18, 2024
| orm: orm, | ||
| } | ||
| r.Service, r.eng = services.Config{ | ||
| Name: "RetirementReportCache", |
There was a problem hiding this comment.
Maybe this should include some kind of LLO prefix since it shows up as a root/global service in the hierarchy.
patrickhuie19
previously approved these changes
Oct 18, 2024
samsondav
dismissed stale reviews from patrickhuie19, vyzaldysanchez, kalverra, msuchacz-cll, and akuzni2
via
f364377
AER Report: CI Core ran successfully ✅AER Report: Operator UI CI ran successfully ✅ |
patrickhuie19
approved these changes
Oct 18, 2024
samsondav
requested review from
jmank88,
vyzaldysanchez,
kalverra,
akuzni2 and
msuchacz-cll
vyzaldysanchez
approved these changes
Oct 18, 2024
kalverra
approved these changes
Oct 18, 2024
|
Fletch153
approved these changes
Oct 18, 2024
winder
pushed a commit
that referenced
this pull request
Oct 21, 2024
* Blue/green deployments for LLO; code cleanup * Go mod tidy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR finally fleshes out the original vision of the parallel compositions plugin, implementing support for blue/green deploys and gapless handovers via retirement reports.
Requires
smartcontractkit/chainlink-data-streams#81
smartcontractkit/chainlink-common#835
Resolves