Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

classify arbitrum sequencer inaccessible error as retryable #14100

Merged
merged 7 commits into from
Aug 13, 2024
Merged

classify arbitrum sequencer inaccessible error as retryable #14100

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
16b177a
add error handling for service unavailable for arbitrum
huangzhen1997 Aug 12, 2024
f385e2e
add changeset
huangzhen1997 Aug 12, 2024
e1ea528
Merge branch 'develop' into BCI-3893/classify-arbitrum-sequencer-erro…
huangzhen1997 Aug 12, 2024
021d440
update error message
huangzhen1997 Aug 13, 2024
fbbfc2f
Merge branch 'develop' into BCI-3893/classify-arbitrum-sequencer-erro…
huangzhen1997 Aug 13, 2024
41d3306
Merge branch 'develop' into BCI-3893/classify-arbitrum-sequencer-erro…
huangzhen1997 Aug 13, 2024
1b3f6c6
Merge branch 'develop' into BCI-3893/classify-arbitrum-sequencer-erro…
prashantkumar1982 Aug 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/calm-badgers-jump.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"chainlink": minor
---

add error handling when arbitrum sequencer is not accessible #added
2 changes: 1 addition & 1 deletion core/chains/evm/client/errors.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ var arbitrum = ClientErrors{
Fatal: arbitrumFatal,
L2FeeTooLow: regexp.MustCompile(`(: |^)max fee per gas less than block base fee(:|$)`),
L2Full: regexp.MustCompile(`(: |^)(queue full|sequencer pending tx pool full, please try again)(:|$)`),
ServiceUnavailable: regexp.MustCompile(`(: |^)502 Bad Gateway: [\s\S]*$`),
ServiceUnavailable: regexp.MustCompile(`(: |^)502 Bad Gateway: [\s\S]*$|network is unreachable|observed invariant violation on SendTransaction`),
Copy link
Contributor Author

@huangzhen1997 huangzhen1997 Aug 12, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dhaidashenko Are these two error messages enough ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have some docs we could link for these? because invariant violation on SendTransaction reads like it could be considered Fatal, so we should link any explanation that we can.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@huangzhen1997 invariant violation is logged by MultiNode when we find contradictions in RPCs responses.
Usually, when we see such log msgs, we need to adjust classification for errors that were logged as Unknown in the resultsByCode field of invariant violation on SendTransaction log.
For this particular case it's network is unreachable and i/o timeout

}

var celo = ClientErrors{
Expand Down
2 changes: 2 additions & 0 deletions core/chains/evm/client/errors_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,6 +229,8 @@ func Test_Eth_Errors(t *testing.T) {
tests := []errorCase{
{"call failed: 503 Service Unavailable: <html>\r\n<head><title>503 Service Temporarily Unavailable</title></head>\r\n<body>\r\n<center><h1>503 Service Temporarily Unavailable</h1></center>\r\n</body>\r\n</html>\r\n", true, "Nethermind"},
{"call failed: 502 Bad Gateway: <html>\r\n<head><title>502 Bad Gateway</title></head>\r\n<body>\r\n<center><h1>502 Bad Gateway</h1></center>\r\n<hr><center>", true, "Arbitrum"},
{"observed invariant violation on SendTransaction", true, "Arbitrum"},
{"network is unreachable", true, "Arbitrum"},
{"client error service unavailable", true, "tomlConfig"},
}
for _, test := range tests {
Expand Down
Loading