make billing more flexible in VRF 2.5 #11909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jinhoonbang
commented
Jan 26, 2024
jinhoonbang
commented
- percentage based billing - flat fee denominated in native
|
I see that you haven't updated any CHANGELOG files. Would it make sense to do so? |
…nd-flat-fee-denominated-in-native
jinhoonbang
force-pushed
the
VRF-831-billing-support-both-percentage-and-flat-fee-denominated-in-native
branch
from
977d5c5 to
365dba3
Compare
Comment on lines
+511
to
+518
| uint256 baseFeeWei = weiPerUnitGas * (s_config.gasAfterPaymentCalculation + startGas - gasleft()); | ||
| // calculate flat fee in native | ||
| uint256 flatFeeWei = 1e12 * uint256(s_config.fulfillmentFlatFeeNativePPM); | ||
| if (onlyPremium) { | ||
| return uint96((((l1CostWei + baseFeeWei) * (s_config.nativePremiumPercentage)) / 100) + flatFeeWei); | ||
| } else { | ||
| return uint96((((l1CostWei + baseFeeWei) * (100 + s_config.nativePremiumPercentage)) / 100) + flatFeeWei); | ||
| } |
There was a problem hiding this comment.
Can save some bytecode
uint8 nativePercentage = s_config.nativePremiumPercentage;
if (!onlyPremium) {
nativePercentage += 100;
}
return uint96((((l1CostWei + baseFeeWei) * nativePercentage) / 100) + flatFeeWei);
There was a problem hiding this comment.
will result in higher gas cost. leaving as is
|
SonarQube Quality Gate
|
kidambisrinivas
approved these changes
Jan 26, 2024
jinhoonbang
deleted the
VRF-831-billing-support-both-percentage-and-flat-fee-denominated-in-native
branch
jinhoonbang
added a commit
that referenced
this pull request
Feb 15, 2024
* make billing more flexible in VRF 2.5 - percentage based billing - flat fee denominated in native * fix linting issues * address comments and fix failing tests * run goimports * fix linting issue
jinhoonbang
added a commit
that referenced
this pull request
Feb 16, 2024
* make billing more flexible in VRF 2.5 - percentage based billing - flat fee denominated in native * fix linting issues * address comments and fix failing tests * run goimports * fix linting issue
This was referenced Feb 16, 2024
jinhoonbang
added a commit
that referenced
this pull request
Feb 16, 2024
* make billing more flexible in VRF 2.5 - percentage based billing - flat fee denominated in native * fix linting issues * address comments and fix failing tests * run goimports * fix linting issue
snehaagni
added a commit
that referenced
this pull request
Feb 20, 2024
…9.1-vrf-20240216 make billing more flexible in VRF 2.5 (#11909)
kidambisrinivas
pushed a commit
that referenced
this pull request
Mar 18, 2024
* make billing more flexible in VRF 2.5 - percentage based billing - flat fee denominated in native * fix linting issues * address comments and fix failing tests * run goimports * fix linting issue
kidambisrinivas
pushed a commit
that referenced
this pull request
Mar 18, 2024
* make billing more flexible in VRF 2.5 - percentage based billing - flat fee denominated in native * fix linting issues * address comments and fix failing tests * run goimports * fix linting issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.