exclude debug.go #11866
Merged
exclude debug.go #11866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see that you haven't updated any README files. Would it make sense to do so? |
|
SonarQube Quality Gate
|
ogtownsend
approved these changes
Jan 23, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This was referenced Feb 22, 2024
This was referenced Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sync-ed with team, we have decided to exclude the script from sonar checks for now rather than spending time making the cosmetic surgery to make the debug function more modular. Some reasons as following:
This debug.go is a script, and we might need to completely change this within half a year so as to reflect our logic in the backend or contract.
We plan to have UI for the debugging script, so we will need to define the protocols to integrate with front end. so that will require some refactoring of the code
with the waterfall mode in the debugging script, it is relatively easy to understand the steps. Moving to smaller functions requires passing in a ton of params, making the code not as clean.
the script is "low fidelity prototype", should iterate quickly