-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Always checkout repo in workflow to support argo sync and rename image tag #11846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chainchad
requested review from
javuto,
jkongie,
jmank88 and
samsondav
as code owners
January 22, 2024 20:21
I see that you haven't updated any CHANGELOG files. Would it make sense to do so? |
erikburt
previously approved these changes
Jan 22, 2024
To avoid collisions.
chainchad
force-pushed
the
fix/untrusted-pr-checkout
branch
from
January 22, 2024 20:51
0d5427e
to
f994e8d
Compare
chainchad
changed the title
Always checkout repo in workflow to support argo sync
Always checkout repo in workflow to support argo sync and rename image tag
Jan 22, 2024
This reverts commit f994e8d.
erikburt
approved these changes
Jan 22, 2024
SonarQube Quality Gate |
This was referenced Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise the PR label check step fails.