Improve on-chain config docs #11700
Merged
Improve on-chain config docs #11700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see that you haven't updated any README files. Would it make sense to do so? |
|
@samsondav there are still some "OCR2" references within the document around core node, i'm guessing these will need updating |
Fletch153
approved these changes
Jan 11, 2024
|
SonarQube Quality Gate
|
kaleofduty
reviewed
Jan 11, 2024
| "feedId": "0x14e044f932bb959cc2aa8dc1ba110c09224e639aae00264c1ffc2a0830904a3c", | ||
| "chainId": 42161, // source chain id | ||
| "contractAddress": "0x14e044f932bb959cc2aa8dc1ba110c09224e639a", // verifier contract address | ||
| "configCount": 1, // the index of this config |
There was a problem hiding this comment.
what does that mean, "index of this config"?
kaleofduty
reviewed
Jan 11, 2024
| "0x000....12", | ||
| "0x000....13", | ||
| "0x000....14" | ||
| ], // NOP transmitter addresses |
There was a problem hiding this comment.
are these filled in or do they remain dummy values?
kaleofduty
reviewed
Jan 11, 2024
| }, | ||
| "offchainConfigVersion": 30, | ||
| "onchainConfig": { | ||
| "max": "99999999999999999999999999999", |
There was a problem hiding this comment.
Is this right? I thought in DF 1.0 we use a different, higher max.
This was referenced Feb 22, 2024
This was referenced Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.