Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core/services/relay/evm/mercury: use chainlink-data-streams #11293

Merged
merged 1 commit into from
Dec 4, 2023
Merged

core/services/relay/evm/mercury: use chainlink-data-streams #11293

merged 1 commit into from
Dec 4, 2023

Conversation

jmank88
Copy link
Contributor

@jmank88 jmank88 commented Nov 14, 2023

@jmank88 jmank88 mentioned this pull request Nov 14, 2023
Merged
@github-actions GitHub Actions
Copy link
Contributor

I see that you haven't updated any CHANGELOG files. Would it make sense to do so?

@github-actions GitHub Actions
Copy link
Contributor

I see that you haven't updated any README files. Would it make sense to do so?

@jmank88 jmank88 mentioned this pull request Nov 14, 2023
Merged
@jmank88 jmank88 force-pushed the BCF-2737-mv-mercury branch 13 times, most recently from 630fc6a to c7b776c Compare November 15, 2023 13:47
krehermann
krehermann reviewed Nov 15, 2023
View reviewed changes
Copy link
Contributor

@krehermann krehermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we expect that we'll be able to line up all the changes such that all the tests in this repo pass on this branch when the deps are pointing to the PRs in the relayer and mercury repos, right?

@jmank88 jmank88 force-pushed the BCF-2737-mv-mercury branch 4 times, most recently from 68a9919 to 1cdc2c9 Compare November 15, 2023 21:28
@jmank88 jmank88 changed the title core/services/relay/evm/mercury: use chainlink-mercury core/services/relay/evm/mercury: use chainlink-llo Nov 28, 2023
@jmank88 jmank88 force-pushed the BCF-2737-mv-mercury branch 5 times, most recently from e150a5d to 9aa77ad Compare November 30, 2023 19:47
@jmank88 jmank88 changed the title core/services/relay/evm/mercury: use chainlink-llo core/services/relay/evm/mercury: use chainlink-data-streams Nov 30, 2023
@jmank88 jmank88 force-pushed the BCF-2737-mv-mercury branch from 9aa77ad to c1e7958 Compare November 30, 2023 19:51
@jmank88 jmank88 force-pushed the BCF-2737-mv-mercury branch 3 times, most recently from 5224596 to 3f7e1fd Compare December 2, 2023 12:55
@jmank88 jmank88 requested a review from a team December 2, 2023 13:05
samsondav
samsondav previously approved these changes Dec 4, 2023
View reviewed changes
@jmank88 jmank88 force-pushed the BCF-2737-mv-mercury branch from 3f7e1fd to 4e4bbf8 Compare December 4, 2023 15:32
@jmank88 jmank88 marked this pull request as ready for review December 4, 2023 15:32
@jmank88 jmank88 requested review from a team, sdrug, martin-cll and connorwstein as code owners December 4, 2023 15:32
@jmank88 jmank88 requested a review from samsondav December 4, 2023 15:32
@cl-sonarqube-production
Copy link

SonarQube Quality Gate

Quality Gate failed

Failed condition 4.5% 4.51% Duplicated Lines (%) on New Code (is greater than 3%)

See analysis details on SonarQube

@jmank88 jmank88 enabled auto-merge December 4, 2023 15:49
@jmank88 jmank88 added this pull request to the merge queue Dec 4, 2023
Merged via the queue into develop with commit 2f17dd6 Dec 4, 2023
86 of 87 checks passed
@jmank88 jmank88 deleted the BCF-2737-mv-mercury branch December 4, 2023 16:12
fbac pushed a commit that referenced this pull request Dec 14, 2023
@jmank88
core/services/relay/evm/mercury: use chainlink-data-streams (#11293)
e360c6d
This was referenced Feb 22, 2024
Closed
Closed
@snehaagni snehaagni mentioned this pull request Mar 7, 2024
Closed
This was referenced Mar 21, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krehermann krehermann krehermann left review comments

@samsondav samsondav samsondav approved these changes

@sdrug sdrug Awaiting requested review from sdrug

@martin-cll martin-cll Awaiting requested review from martin-cll

@connorwstein connorwstein Awaiting requested review from connorwstein

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jmank88 @samsondav @krehermann