PR fixes

smartcontractkit · Jan 29, 2025 · e6692eb · e6692eb
1 parent 2ec827c
commit e6692eb
Show file tree

Hide file tree

Showing 6 changed files with 144 additions and 154 deletions.
diff --git a/core/capabilities/remote/types/messages.pb.go b/core/capabilities/remote/types/messages.pb.go
diff --git a/core/services/llo/attested_retirement_report.pb.go b/core/services/llo/attested_retirement_report.pb.go
diff --git a/core/services/llo/data_source_test.go b/core/services/llo/data_source_test.go
@@ -180,8 +180,6 @@ func Test_DataSource(t *testing.T) {
 			err := ds.Observe(ctx, vals, opts)
 			require.NoError(t, err)
 
-			close(tm.ch)
-
 			assert.Equal(t, llo.StreamValues{
 				2: llo.ToDecimal(decimal.NewFromInt(40602)),
 				1: llo.ToDecimal(decimal.NewFromInt(2181)),
@@ -199,7 +197,7 @@ func Test_DataSource(t *testing.T) {
 			assert.Equal(t, 1, int(pkt.streamID))
 			assert.Equal(t, opts, pkt.opts)
 			assert.Equal(t, "2181", pkt.val.(*llo.Decimal).String())
-			assert.NoError(t, pkt.err)
+			require.NoError(t, pkt.err)
 
 			telems := []interface{}{}
 			for p := range tm.ch {
@@ -209,7 +207,7 @@ func Test_DataSource(t *testing.T) {
 			sort.Slice(telems, func(i, j int) bool {
 				return telems[i].(*telem.LLOObservationTelemetry).StreamId < telems[j].(*telem.LLOObservationTelemetry).StreamId
 			})
-			require.IsType(t, telems[0], &telem.LLOObservationTelemetry{})
+			require.IsType(t, &telem.LLOObservationTelemetry{}, telems[0])
 			obsTelem := telems[0].(*telem.LLOObservationTelemetry)
 			assert.Equal(t, uint32(1), obsTelem.StreamId)
 			assert.Equal(t, int32(llo.LLOStreamValue_Decimal), obsTelem.StreamValueType)