Skip to content

Commit

Permalink
remove time.Sleep, update docstrings
Browse files Browse the repository at this point in the history
  • Loading branch information
makramkd committed Jan 17, 2025
1 parent 286c95e commit 8c94e4d
Showing 1 changed file with 6 additions and 9 deletions.
15 changes: 6 additions & 9 deletions integration-tests/smoke/ccip/ccip_add_chain_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ import (
"math/big"
"slices"
"testing"
"time"

"github.com/ethereum/go-ethereum/accounts/abi/bind"
"github.com/ethereum/go-ethereum/common"
Expand Down Expand Up @@ -153,8 +152,6 @@ func Test_AddChain(t *testing.T) {
return gasPricePreUpdate, startBlocks
}

// wait for plugins to come up.
time.Sleep(30 * time.Second)
sendMsgs(toDeploy, toDeploy, false)

/////////////////////////////////////
Expand Down Expand Up @@ -554,9 +551,9 @@ func setupChain(t *testing.T, e testhelpers.DeployedEnv, tEnv testhelpers.TestEn
return e
}

// assertChainWiringInbound checks that the new chain has the existing chains enabled as sources.
// It only checks the inbound wiring on the new chain.
// It doesn't check that the existing chains have the new chain enabled as a dest.
// assertChainWiringInbound checks that the newChain has the existingChains enabled as sources.
// It only checks the inbound wiring on the newChain.
// It doesn't check that the existingChains have the newChain enabled as a dest.
func assertChainWiringInbound(
t *testing.T,
state ccipcs.CCIPOnChainState,
Expand Down Expand Up @@ -597,9 +594,9 @@ func assertChainWiringInbound(
}
}

// assertChainWiringOutbound checks that the new chain can be requested from the existing chains.
// This only checks the outbound wiring on the existing chains.
// It doesn't check that the new chain can process the requests.
// assertChainWiringOutbound checks that newChain can be requested from existingChains.
// This only checks the outbound wiring on existingChains.
// It doesn't check that the newChain can process the requests.
func assertChainWiringOutbound(
t *testing.T,
state ccipcs.CCIPOnChainState,
Expand Down

0 comments on commit 8c94e4d

Please sign in to comment.