Skip to content

Commit

Permalink
cosmetic updates on workflow registry deployment (#15874)
Browse files Browse the repository at this point in the history
* cosmetic updates on workflow registry deployment

* Trigger re-deploy

---------

Co-authored-by: Justin Kaseman <[email protected]>
  • Loading branch information
shileiwill and justinkaseman authored Jan 14, 2025
1 parent 8cab05a commit 1e25959
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 10 deletions.
2 changes: 1 addition & 1 deletion deployment/keystone/changeset/workflowregistry/deploy.go
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ func Deploy(env deployment.Environment, registrySelector uint64) (deployment.Cha
ab := deployment.NewMemoryAddressBook()
wrResp, err := deployWorkflowRegistry(chain, ab)
if err != nil {
return deployment.ChangesetOutput{}, fmt.Errorf("failed to deploy CapabilitiesRegistry: %w", err)
return deployment.ChangesetOutput{}, fmt.Errorf("failed to deploy WorkflowRegistry: %w", err)
}
lggr.Infof("Deployed %s chain selector %d addr %s", wrResp.Tv.String(), chain.Selector, wrResp.Address.String())

Expand Down
4 changes: 2 additions & 2 deletions deployment/keystone/changeset/workflowregistry/deploy_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -26,12 +26,12 @@ func Test_Deploy(t *testing.T) {
resp, err := Deploy(env, registrySel)
require.NoError(t, err)
require.NotNil(t, resp)
// OCR3 should be deployed on chain 0
// workflow registry should be deployed on chain 0
addrs, err := resp.AddressBook.AddressesForChain(registrySel)
require.NoError(t, err)
require.Len(t, addrs, 1)

// nothing on chain 1
// assert nothing on chain 1
require.NotEqual(t, registrySel, env.AllChainSelectors()[1])
oaddrs, _ := resp.AddressBook.AddressesForChain(env.AllChainSelectors()[1])
assert.Empty(t, oaddrs)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,10 @@ func TestUpdateAuthorizedAddresses(t *testing.T) {
resp := workflowregistry.SetupTestWorkflowRegistry(t, lggr, chainSel)
registry := resp.Registry

dons, err := registry.GetAllAuthorizedAddresses(&bind.CallOpts{})
authorizedAddresses, err := registry.GetAllAuthorizedAddresses(&bind.CallOpts{})
require.NoError(t, err)

assert.Empty(t, dons)
assert.Empty(t, authorizedAddresses)

env := deployment.Environment{
Logger: lggr,
Expand All @@ -51,11 +51,11 @@ func TestUpdateAuthorizedAddresses(t *testing.T) {
)
require.NoError(t, err)

dons, err = registry.GetAllAuthorizedAddresses(&bind.CallOpts{})
authorizedAddresses, err = registry.GetAllAuthorizedAddresses(&bind.CallOpts{})
require.NoError(t, err)

assert.Len(t, dons, 1)
assert.Equal(t, dons[0], common.HexToAddress(addr))
assert.Len(t, authorizedAddresses, 1)
assert.Equal(t, authorizedAddresses[0], common.HexToAddress(addr))

_, err = workflowregistry.UpdateAuthorizedAddresses(
env,
Expand All @@ -67,10 +67,10 @@ func TestUpdateAuthorizedAddresses(t *testing.T) {
)
require.NoError(t, err)

dons, err = registry.GetAllAuthorizedAddresses(&bind.CallOpts{})
authorizedAddresses, err = registry.GetAllAuthorizedAddresses(&bind.CallOpts{})
require.NoError(t, err)

assert.Empty(t, dons)
assert.Empty(t, authorizedAddresses)
}

func Test_UpdateAuthorizedAddresses_WithMCMS(t *testing.T) {
Expand Down

0 comments on commit 1e25959

Please sign in to comment.