Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumping the setup-github-token action to version 0.2.1 #734

Merged
merged 2 commits into from
Jun 4, 2024

Conversation

njegosrailic
Copy link
Contributor

@njegosrailic njegosrailic commented Jun 4, 2024

What

  • Bumping the setup-github-token action to version 0.2.1
  • Adding code owners for the RelEng team

Ticket: https://smartcontract-it.atlassian.net/browse/RE-1943

Why

The setup-github-token action should have a role session name parameter which it passes to the configure-aws-credentials step.

@njegosrailic njegosrailic marked this pull request as ready for review June 4, 2024 15:18
@njegosrailic njegosrailic requested a review from a team as a code owner June 4, 2024 15:18
@njegosrailic njegosrailic requested a review from momentmaker June 4, 2024 15:18
momentmaker
momentmaker previously approved these changes Jun 4, 2024
@momentmaker
Copy link
Contributor

I think we might need to add our team to the CODEOWNERS for .github like in order to get this approved just by us.

/.github @smartcontractkit/releng 

@momentmaker
Copy link
Contributor

hmm I guess not - we need someone who is an authorized user to merge

@aalu1418 aalu1418 merged commit 4f726d1 into develop Jun 4, 2024
25 checks passed
@aalu1418 aalu1418 deleted the nrailic-releng-1943 branch June 4, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants