-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bumping the setup-github-token action to version 0.2.1 #734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
momentmaker
reviewed
Jun 4, 2024
njegosrailic
force-pushed
the
nrailic-releng-1943
branch
from
June 4, 2024 15:33
6c53916
to
f041773
Compare
njegosrailic
force-pushed
the
nrailic-releng-1943
branch
from
June 4, 2024 15:34
f041773
to
dc3d66b
Compare
momentmaker
previously approved these changes
Jun 4, 2024
I think we might need to add our team to the CODEOWNERS for
|
momentmaker
approved these changes
Jun 4, 2024
hmm I guess not - we need someone who is an authorized user to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Ticket: https://smartcontract-it.atlassian.net/browse/RE-1943
Why
The setup-github-token action should have a role session name parameter which it passes to the configure-aws-credentials step.