Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Satisfy Relayer interface with unsupported NewContractReader impl. #718

Merged
merged 4 commits into from
May 24, 2024
Merged

Satisfy Relayer interface with unsupported NewContractReader impl. #718

merged 4 commits into from
May 24, 2024

Conversation

ilija42
Copy link
Contributor

@ilija42 ilija42 commented May 22, 2024 •
edited by aalu1418
Loading

core ref: 7a51959eb75a03d9bf8f4be20f96d20b18c92e6d

@ilija42 ilija42 requested review from a team as code owners May 22, 2024 10:51
@ilija42 ilija42 force-pushed the relay-contractreader branch from 5a5d535 to 351e6bb Compare May 23, 2024 14:27
This was referenced May 23, 2024
Merged
Merged
@ilija42 ilija42 force-pushed the relay-contractreader branch from 351e6bb to d21e237 Compare May 23, 2024 15:42
@ilija42 ilija42 force-pushed the relay-contractreader branch from d21e237 to 911450d Compare May 23, 2024 16:01
@ilija42 ilija42 requested review from jmank88 and aalu1418 May 23, 2024 16:24
@ilija42 ilija42 requested a review from aalu1418 May 24, 2024 16:30
@aalu1418 aalu1418 enabled auto-merge (squash) May 24, 2024 19:31
@cl-sonarqube-production
Copy link

Quality Gate failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 75%)

See analysis details on SonarQube

@aalu1418 aalu1418 merged commit 88d0b37 into develop May 24, 2024
46 of 47 checks passed
@aalu1418 aalu1418 deleted the relay-contractreader branch May 24, 2024 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aalu1418 aalu1418 aalu1418 approved these changes

@jmank88 jmank88 Awaiting requested review from jmank88

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ilija42 @aalu1418