Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go mod tidy #61

Merged
merged 1 commit into from
Dec 20, 2021
Merged

go mod tidy #61

merged 1 commit into from
Dec 20, 2021

Conversation

krebernisak
Copy link
Collaborator

No description provided.

@krebernisak krebernisak requested a review from aalu1418 December 20, 2021 17:55
aalu1418
aalu1418 reviewed Dec 20, 2021
View reviewed changes
Copy link
Collaborator

@aalu1418 aalu1418 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These packages look like they are from the e2e QA testing...is that something we want included in the relay pkg? (it would be nice to keep the relay module as light weight as possible)

@krebernisak krebernisak mentioned this pull request Dec 20, 2021
Closed
2 tasks
@krebernisak
Copy link
Collaborator Author

@aalu1418 I've just run go mod tidy here and did not add anything extra.

I don't know a solution to the problem you are suggesting, so I've opened this issue to track:

aalu1418
aalu1418 approved these changes Dec 20, 2021
View reviewed changes
Copy link
Collaborator

@aalu1418 aalu1418 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 approving for now, and we can revisit with the issue at a later point!

@krebernisak krebernisak merged commit ac8e7dc into develop Dec 20, 2021
@krebernisak krebernisak deleted the chore/go-mod-tidy branch December 20, 2021 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aalu1418 aalu1418 aalu1418 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krebernisak @aalu1418