Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BCF-2685: move LOOPP command from core #550

Merged
merged 2 commits into from
Oct 23, 2023
Merged

BCF-2685: move LOOPP command from core #550

merged 2 commits into from
Oct 23, 2023

Conversation

jmank88
Copy link
Contributor

@jmank88 jmank88 commented Oct 10, 2023 •
edited
Loading

@jmank88 jmank88 temporarily deployed to integration October 10, 2023 13:52 — with GitHub Actions Inactive
@jmank88 jmank88 temporarily deployed to integration October 10, 2023 13:52 — with GitHub Actions Inactive
@jmank88 jmank88 temporarily deployed to integration October 10, 2023 13:52 — with GitHub Actions Inactive
@jmank88 jmank88 temporarily deployed to integration October 10, 2023 13:52 — with GitHub Actions Inactive
@jmank88 jmank88 changed the title pkg/solana: copy chains/solana packages from core BCF-2685: move LOOPP command from core Oct 10, 2023
@jmank88 jmank88 force-pushed the BCF-2685-solana-loopp-extraction branch from 526c18f to 033963c Compare October 16, 2023 17:45
@jmank88 jmank88 temporarily deployed to integration October 16, 2023 17:45 — with GitHub Actions Inactive
@jmank88 jmank88 temporarily deployed to integration October 16, 2023 17:45 — with GitHub Actions Inactive
@jmank88 jmank88 temporarily deployed to integration October 16, 2023 17:45 — with GitHub Actions Inactive
@jmank88 jmank88 mentioned this pull request Oct 16, 2023
Merged
@jmank88 jmank88 mentioned this pull request Oct 16, 2023
Merged
krehermann
krehermann previously approved these changes Oct 16, 2023
View reviewed changes
patrickhuie19
patrickhuie19 previously approved these changes Oct 16, 2023
View reviewed changes
@jmank88 jmank88 dismissed stale reviews from patrickhuie19 and krehermann via 6c8aa26 October 17, 2023 15:58
@jmank88 jmank88 force-pushed the BCF-2685-solana-loopp-extraction branch from 033963c to 6c8aa26 Compare October 17, 2023 15:58
@jmank88 jmank88 temporarily deployed to integration October 17, 2023 15:58 — with GitHub Actions Inactive
@jmank88 jmank88 temporarily deployed to integration October 17, 2023 15:58 — with GitHub Actions Inactive
@jmank88 jmank88 temporarily deployed to integration October 17, 2023 15:58 — with GitHub Actions Inactive
@jmank88 jmank88 force-pushed the BCF-2685-solana-loopp-extraction branch from 6c8aa26 to 40d0a39 Compare October 17, 2023 16:31
@jmank88 jmank88 temporarily deployed to integration October 17, 2023 16:31 — with GitHub Actions Inactive
@jmank88 jmank88 temporarily deployed to integration October 17, 2023 16:31 — with GitHub Actions Inactive
@jmank88 jmank88 temporarily deployed to integration October 17, 2023 16:31 — with GitHub Actions Inactive
@jmank88 jmank88 force-pushed the BCF-2685-solana-loopp-extraction branch from 0b428fa to aef5946 Compare October 20, 2023 22:09
@jmank88 jmank88 temporarily deployed to integration October 20, 2023 22:09 — with GitHub Actions Inactive
@jmank88 jmank88 temporarily deployed to integration October 20, 2023 22:09 — with GitHub Actions Inactive
@jmank88 jmank88 temporarily deployed to integration October 20, 2023 22:09 — with GitHub Actions Inactive
patrickhuie19
patrickhuie19 previously approved these changes Oct 20, 2023
View reviewed changes
@jmank88 jmank88 temporarily deployed to integration October 20, 2023 23:05 — with GitHub Actions Inactive
@jmank88 jmank88 temporarily deployed to integration October 20, 2023 23:05 — with GitHub Actions Inactive
@jmank88 jmank88 marked this pull request as ready for review October 20, 2023 23:05
@jmank88 jmank88 temporarily deployed to integration October 20, 2023 23:05 — with GitHub Actions Inactive
@jmank88 jmank88 force-pushed the BCF-2685-solana-loopp-extraction branch from 0634aa2 to cb0b130 Compare October 21, 2023 23:02
@jmank88 jmank88 temporarily deployed to integration October 21, 2023 23:02 — with GitHub Actions Inactive
@jmank88 jmank88 temporarily deployed to integration October 21, 2023 23:02 — with GitHub Actions Inactive
@jmank88 jmank88 temporarily deployed to integration October 21, 2023 23:02 — with GitHub Actions Inactive
@cl-sonarqube-production
Copy link

SonarQube Quality Gate

Quality Gate failed

Failed condition 0.0% 0.0% Coverage on New Code (is less than 80%)

See analysis details on SonarQube

@jmank88 jmank88 requested a review from krehermann October 22, 2023 11:31
@jmank88
Copy link
Contributor Author

jmank88 commented Oct 22, 2023

@aalu1418 This is stable and e2e is passing on core side:

@aalu1418 aalu1418 merged commit 72f4e79 into develop Oct 23, 2023
22 of 24 checks passed
@aalu1418 aalu1418 deleted the BCF-2685-solana-loopp-extraction branch October 23, 2023 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aalu1418 aalu1418 aalu1418 approved these changes

@patrickhuie19 patrickhuie19 patrickhuie19 approved these changes

@krehermann krehermann krehermann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jmank88 @krehermann @patrickhuie19 @aalu1418