Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: startup panic if solana endpoint is not valid #177

Merged
merged 2 commits into from
Feb 2, 2022

Conversation

aalu1418
Copy link
Collaborator

@aalu1418 aalu1418 commented Feb 2, 2022

Problem: node on startup will panic if endpoint is not valid and there are existing jobs

Cause:

Fix:

  • initialize time to 0 which will throw an error for an uninitialized state (and will keep throwing an error to indicate an issue with polling and the endpoint)

Testing: ✅

  • tested locally: start up network + nodes + feed => shut down a node => stop local network => start up the stopped node
    • previously would panic at this step
    • now shows error logs related to polling and failed to fetch state/data
    • => start up local network again => all nodes join again ✅

@aalu1418 aalu1418 marked this pull request as ready for review February 2, 2022 23:05
@aalu1418 aalu1418 requested a review from krebernisak February 2, 2022 23:05
Co-authored-by: Jordan Krage <[email protected]>
@aalu1418 aalu1418 merged commit 1d5afb6 into develop Feb 2, 2022
@aalu1418 aalu1418 deleted the fix/panic-on-startup-endpoint branch February 2, 2022 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants