Multisig command export and execute options #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
archseer
reviewed
Jan 28, 2022
RodrigoAD
force-pushed
the
multisig-export-tx
branch
from
557ddfd to
8d1d8d6
Compare
krebernisak
reviewed
Jan 28, 2022
gauntlet/packages/gauntlet-serum-multisig/src/commands/inspect.ts
Outdated
Show resolved
Hide resolved
gauntlet/packages/gauntlet-serum-multisig/src/commands/multisig.ts
Outdated
Show resolved
Hide resolved
gauntlet/packages/gauntlet-serum-multisig/src/commands/multisig.ts
Outdated
Show resolved
Hide resolved
krebernisak
reviewed
Jan 28, 2022
| @@ -1,5 +1,5 @@ | |||
| { | |||
| "version": "0.0.0", | |||
| "version": "0.8.0", | |||
There was a problem hiding this comment.
This one should be "version": "0.9.0". You can take it from the multisig PR #157.
* added local and ledger wallet support * Commands inherits multiig wallet * refactor and improvements * More IDL wrappings and improvements * Improved logging information * Small improvements on msig commands
…nlink-solana into multisig-export-tx
krebernisak
approved these changes
Feb 3, 2022
|
|
||
| export default class SetOwners extends SolanaCommand { | ||
| static id = 'set:owners' | ||
| static id = 'set_owners' |
There was a problem hiding this comment.
As we namespace other commands we should do the same here:
Suggested change
| static id = 'set_owners' | |
| static id = 'multisig:set_owners' |
This is consistent with multisig:inspect.
| static examples = [ | ||
| 'yarn gauntlet-serum-multisig set:owners --network=local --approve --tx=9Vck9Gdk8o9WhxT8bgNcfJ5gbvFBN1zPuXpf8yu8o2aq --execute AGnZeMWkdyXBiLDG2DnwuyGSviAbCGJXyk4VhvP9Y51M QMaHW2Fpyet4ZVf7jgrGB6iirZLjwZUjN9vPKcpQrHs', | ||
| ] | ||
| static examples = ['yarn gauntlet-serum-multisig set_owners --network=local'] |
There was a problem hiding this comment.
Suggested change
| static examples = ['yarn gauntlet-serum-multisig set_owners --network=local'] | |
| static examples = ['yarn gauntlet-serum-multisig set_owners --network=local [OWNERS...]'] |
|
|
||
| export default class SetThreshold extends SolanaCommand { | ||
| static id = 'set:threshold' | ||
| static id = 'set_threshold' |
There was a problem hiding this comment.
Suggested change
| static id = 'set_threshold' | |
| static id = 'multisig:set_threshold' |
There was a problem hiding this comment.
It should probably be multisig:change_threshold as this is the instruction we call.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--executeis provided, will use local wallet to sign and broadcast the tx