Update job specs examples #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aalu1418
reviewed
Jan 25, 2022
examples/spec/ocr2-oracle.spec.toml
Outdated
Comment on lines
76
to
80
| usePreflight = false | ||
| commitment = "confirmed" | ||
| pollingInterval = "1s" | ||
| pollingCtxTimeout = "2s" | ||
| staleTimeout = "1m" |
There was a problem hiding this comment.
these are optional parameters, there are defaults included in the relay...not sure if we should have them here or not
There was a problem hiding this comment.
if you wanted to include these, then should they be included in the bootstrap spec too?
There was a problem hiding this comment.
Yup!
- Are all relevant for the bootstrap node?
- Are default values listed or should I fish for default values to document?
There was a problem hiding this comment.
- the
preflightis the only one that is not since it's for transmissions (although it will just default to false anyway) - those are the default values! (the default
pollingCtxTimeoutis calculated via double thepollingInterval)
aalu1418
approved these changes
Jan 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.