Gauntlet Multisig - Reduce create proposal TX size #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebarakos
suggested changes
Jan 25, 2022
| NODE_URL=http://127.0.0.1:8899 | ||
|
|
||
| PROGRAM_ID_MULTISIG=3X4UvrX9gTxSmNmXww53W5dM5fT1Nby246hKV8Mx9LuD |
There was a problem hiding this comment.
Those are constant always on local environment
There was a problem hiding this comment.
PROGRAM_IDs yes, but MULTISIG_ADDRESS is created anew each time, no?
There was a problem hiding this comment.
That's right. Removing those
| @@ -0,0 +1,322 @@ | |||
| { | |||
There was a problem hiding this comment.
Hard-add it here or let it be added along other programs and .so's during Gauntlet setup?
There was a problem hiding this comment.
Let's have it here, in the future will be pulled from GH. But for development is useful
| } catch (e) { | ||
| // known errors, defined in multisig contract. see serum_multisig.json | ||
| if (e.code >= 300 && e.code < 400) { | ||
| logger.error(e.msg) |
There was a problem hiding this comment.
Why removing this logging for known erros?
There was a problem hiding this comment.
This wasn't doing anything. The program already logs this errors automatically
| createProposalAcount = async (): Promise<PublicKey> => { | ||
| logger.log('Creating proposal account') | ||
| const proposal = Keypair.generate() | ||
| const txSize = 1300 // Space enough |
ebarakos
approved these changes
Jan 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.