Make state/transmit configurable + polling state #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aalu1418
commented
Jan 19, 2022
pkg/solana/transmitter.go
Outdated
| @@ -19,7 +18,7 @@ func (c *ContractTracker) Transmit( | |||
| report types.Report, | |||
| sigs []types.AttributedOnchainSignature, | |||
| ) error { | |||
| recent, err := c.client.rpc.GetRecentBlockhash(ctx, rpc.CommitmentFinalized) | |||
| recent, err := c.client.rpc.GetRecentBlockhash(ctx, rpcCommitment) | |||
There was a problem hiding this comment.
switch from CommitmentFinalized to CommitmentConfirmed
aalu1418
changed the title
jmank88
reviewed
Jan 20, 2022
| if err := c.fetchLatestTransmission(ctx); err != nil { | ||
| c.lggr.Errorf("error in PollState.fetchLatestTransmission %s", err) | ||
| } | ||
| }() |
There was a problem hiding this comment.
Should these goroutines cancel on c.done?
Is it OK to proceed without waiting for them to complete?
There was a problem hiding this comment.
that's a good point, it would be good to cancel the context or wait for it to complete.
not sure how to do this off the top of my mind, but i'll do some digging
There was a problem hiding this comment.
package utils has some relevant helpers, e.g. ContextFromChan and WaitGroupChan.
There was a problem hiding this comment.
💯 it had ContextFromChanWithDeadline which is exactly what i needed
i should look through utils more often
aalu1418
force-pushed
the
feature/configurability
branch
from
3f66868 to
321da08
Compare
krebernisak
reviewed
Jan 21, 2022
jmank88
reviewed
Jan 21, 2022
jmank88
reviewed
Jan 21, 2022
jmank88
reviewed
Jan 21, 2022
jmank88
reviewed
Jan 21, 2022
jmank88
approved these changes
Jan 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PR in core: smartcontractkit/chainlink#5838