Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates on main OCR Flow commands #100

Merged
merged 6 commits into from
Jan 12, 2022
Merged

Updates on main OCR Flow commands #100

merged 6 commits into from
Jan 12, 2022

Conversation

RodrigoAD
Copy link
Member

No description provided.

Copy link
Collaborator

@aalu1418 aalu1418 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you might be missing the set_writer command in the flow command?

@RodrigoAD
Copy link
Member Author

I think you might be missing the set_writer command in the flow command?

Ok, adding it now

exec: this.showRddIdentifierInstructions,
},
{
name: 'Set writer on Store',
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aalu1418 This is run right after the OCR2 feed is initialized. I think is correct?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that should work. all you need is the store account (from the initialize store), transmissions account (from the create feed), and storeAuthority (calculated in the ocr2 initialize)

@RodrigoAD RodrigoAD force-pushed the gauntlet-flow-updates branch from 5c03236 to 261f095 Compare January 12, 2022 16:36
@RodrigoAD RodrigoAD force-pushed the gauntlet-flow-updates branch from c58ad58 to da734bc Compare January 12, 2022 17:45
const feed = Keypair.generate()

const granularity = new BN(input.granularity)
const liveLength = new BN(input.liveLength)
const length = new BN(this.flags.length || 8096)
const feedAccountLength = new BN(8 + 128 + length.toNumber() * 24)
const feedAccountLength = new BN(8 + 128 + length.toNumber() * 48)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this still be 24? the transmissions account didn't change

Copy link
Collaborator

@aalu1418 aalu1418 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@RodrigoAD RodrigoAD merged commit 189d8a8 into develop Jan 12, 2022
@RodrigoAD RodrigoAD deleted the gauntlet-flow-updates branch January 12, 2022 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants