Skip to content

Minor

Minor #117

Triggered via push February 1, 2025 18:12
Status Success
Total duration 3m 15s
Artifacts
detect-modules
10s
detect-modules
Matrix: golangci-lint
Fit to window
Zoom out
Zoom in

Annotations

19 errors and 20 warnings
golangci-lint (chains): chains/txmgr/types/tx_test.go#L27
appendAssign: append result not assigned to the same slice (gocritic)
golangci-lint (chains): chains/txmgr/types/tx_test.go#L42
appendAssign: append result not assigned to the same slice (gocritic)
golangci-lint (chains): chains/txmgr/types/stuck_tx_detector.go#L12
File is not `goimports`-ed with -local github.com/smartcontractkit/chainlink (goimports)
golangci-lint (chains): chains/headtracker/head_tracker.go#L229
ifElseChain: rewrite if-else to switch statement (gocritic)
golangci-lint (chains): chains/headtracker/head_broadcaster.go#L22
Consider pre-allocating `values` (prealloc)
golangci-lint (chains): chains/txmgr/broadcaster.go#L599
defaultCaseOrder: consider to make `default` case as first or as last case (gocritic)
golangci-lint (chains): chains/txmgr/broadcaster.go#L760
ifElseChain: rewrite if-else to switch statement (gocritic)
golangci-lint (chains): chains/txmgr/confirmer.go#L465
ifElseChain: rewrite if-else to switch statement (gocritic)
golangci-lint (chains)
issues found
golangci-lint (tools/evm-chain-bindings): tools/evm-chain-bindings/pkg/utils/file.go#L28
non-wrapping format verb for fmt.Errorf. Use `%w` to format errors (errorlint)
golangci-lint (tools/evm-chain-bindings): tools/evm-chain-bindings/pkg/utils/file.go#L33
non-wrapping format verb for fmt.Errorf. Use `%w` to format errors (errorlint)
golangci-lint (tools/evm-chain-bindings): tools/evm-chain-bindings/pkg/utils/file.go#L90
non-wrapping format verb for fmt.Errorf. Use `%w` to format errors (errorlint)
golangci-lint (tools/evm-chain-bindings): tools/evm-chain-bindings/pkg/utils/file.go#L5
SA1019: "io/ioutil" has been deprecated since Go 1.19: As of Go 1.16, the same functionality is now provided by package [io] or package [os], and those implementations should be preferred in new code. See the specific function documentation for details. (staticcheck)
golangci-lint (tools/evm-chain-bindings): tools/evm-chain-bindings/main.go#L114
Error return value of `utils.GenerateFile` is not checked (errcheck)
golangci-lint (tools/evm-chain-bindings): tools/evm-chain-bindings/main.go#L6
File is not `goimports`-ed with -local github.com/smartcontractkit/chainlink (goimports)
golangci-lint (tools/evm-chain-bindings): tools/evm-chain-bindings/main.go#L48
printf: missing ... in args forwarded to printf-like function (govet)
golangci-lint (tools/evm-chain-bindings): tools/evm-chain-bindings/main.go#L53
printf: fmt.Printf call has arguments but no formatting directives (govet)
golangci-lint (tools/evm-chain-bindings): tools/evm-chain-bindings/main.go#L82
printf: fmt.Println call has possible Printf formatting directive %s (govet)
golangci-lint (tools/evm-chain-bindings): tools/evm-chain-bindings/main.go#L102
printf: fmt.Printf format %s reads arg #2, but call has 1 arg (govet)
detect-modules
Restore cache failed: Dependencies file is not found in /home/runner/work/chainlink-framework/chainlink-framework. Supported file pattern: go.sum
golangci-lint (chains)
Restore cache failed: Dependencies file is not found in /home/runner/work/chainlink-framework/chainlink-framework. Supported file pattern: go.sum
golangci-lint (chains): chains/txmgr/txmgrtest/err.go#L83
var-naming: method FindTxesWithAttemptsAndReceiptsByIdsAndState should be FindTxesWithAttemptsAndReceiptsByIDsAndState (revive)
golangci-lint (chains): chains/txmgr/types/keystore.go#L19
var-naming: interface method parameter chainId should be chainID (revive)
golangci-lint (chains): chains/headtracker/head_listener.go#L158
var-naming: var chainId should be chainID (revive)
golangci-lint (chains): chains/headtracker/head_listener.go#L209
var-naming: var chainId should be chainID (revive)
golangci-lint (chains): chains/txmgr/txmgr.go#L150
var-naming: func parameter chainId should be chainID (revive)
golangci-lint (chains): chains/txmgr/txmgr.go#L666
var-naming: method FindTxesWithAttemptsAndReceiptsByIdsAndState should be FindTxesWithAttemptsAndReceiptsByIDsAndState (revive)
golangci-lint (chains): chains/txmgr/txmgr.go#L784
var-naming: method FindTxesWithAttemptsAndReceiptsByIdsAndState should be FindTxesWithAttemptsAndReceiptsByIDsAndState (revive)
golangci-lint (tools/evm-chain-bindings/examples/basic)
Restore cache failed: Dependencies file is not found in /home/runner/work/chainlink-framework/chainlink-framework. Supported file pattern: go.sum
golangci-lint (tools/evm-chain-bindings)
Restore cache failed: Dependencies file is not found in /home/runner/work/chainlink-framework/chainlink-framework. Supported file pattern: go.sum
golangci-lint (tools/evm-chain-bindings): tools/evm-chain-bindings/pkg/utils/string.go#L54
string-of-int: dubious conversion of an integer into a string, use strconv.Itoa (revive)
golangci-lint (tools/evm-chain-bindings): tools/evm-chain-bindings/main.go#L203
unreachable-code: unreachable code after this statement (revive)
golangci-lint (tools/evm-chain-bindings): tools/evm-chain-bindings/pkg/gen/evm/solidity_types_mapping.go#L13
var-declaration: should omit type *regexp.Regexp from declaration of var arrayPattern; it will be inferred from the right-hand side (revive)
golangci-lint (tools/evm-chain-bindings): tools/evm-chain-bindings/pkg/gen/evm/solidity_types_mapping.go#L14
var-declaration: should omit type *regexp.Regexp from declaration of var intPattern; it will be inferred from the right-hand side (revive)
golangci-lint (tools/evm-chain-bindings): tools/evm-chain-bindings/pkg/gen/evm/solidity_types_mapping.go#L92
indent-error-flow: if block ends with a return statement, so drop this else and outdent its block (revive)
golangci-lint (tools/evm-chain-bindings): tools/evm-chain-bindings/pkg/gen/evm/code_descriptor.go#L245
var-declaration: should drop = nil from declaration of var topicFilterStruct; it is the zero value (revive)
golangci-lint (tools/evm-chain-bindings): tools/evm-chain-bindings/pkg/gen/evm/code_descriptor.go#L220
var-naming: func createConstructOwnerId should be createConstructOwnerID (revive)
golangci-lint (tools/evm-chain-bindings): tools/evm-chain-bindings/pkg/gen/evm/code_descriptor.go#L224
error-return: error should be the last type when returning multiple items (revive)
golangci-lint (multinode)
Restore cache failed: Dependencies file is not found in /home/runner/work/chainlink-framework/chainlink-framework. Supported file pattern: go.sum