pkg/services/servicetest: add Run and RunHealthy helpers #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmank88
had a problem deploying
to
integration
GitHub Actions
Failure
jmank88
had a problem deploying
to
integration
GitHub Actions
Failure
1 task
jmank88
had a problem deploying
to
integration
GitHub Actions
Failure
jmank88
had a problem deploying
to
integration
GitHub Actions
Failure
jmank88
requested review from
nolag,
patrickhuie19,
cedric-cordenier and
george-dorin
nolag
previously approved these changes
Nov 27, 2023
jmank88
had a problem deploying
to
integration
GitHub Actions
Failure
jmank88
had a problem deploying
to
integration
GitHub Actions
Failure
jmank88
commented
Nov 27, 2023
| for _, test := range []struct { | ||
| name string | ||
| s services.Service | ||
| expFail bool |
There was a problem hiding this comment.
I tried to validate error messages too, but they contain whole stacks from testify internals.
patrickhuie19
approved these changes
Nov 27, 2023
jmank88
had a problem deploying
to
integration
GitHub Actions
Failure
jmank88
had a problem deploying
to
integration
GitHub Actions
Failure
jmank88
had a problem deploying
to
integration
GitHub Actions
Failure
jmank88
had a problem deploying
to
integration
GitHub Actions
Failure
nolag
added a commit
that referenced
this pull request
Dec 7, 2023
* Logger extraction (#253) Co-authored-by: Jordan Krage <[email protected]> * pkg/services/servicetest: add Run and RunHealthy helpers (#251) * pkg/services/servicetest: remove debug fmt.Println (#259) * Bump MaxAllowedBlocks from 5 to 10 (#260) * pkg/services: add ver & sha params to HealthChecker (#265) * Utils extraction from chainlink repo (#256) * Adjust price scaling factor from 1e8 => 1e18 (#266) * Adjust price scaling factor from 1e8 => 1e18 * Adjust price scaling from 1e8 => 1e18 - Reference: MERC-1771 * Add mathutil (#267) Co-authored-by: Jordan Krage <[email protected]> Co-authored-by: Dmytro Haidashenko <[email protected]> * pkg/reportingplugins: remove; move mercury to chainlink-data-streams (#240) * Add minimal ChainReader interface & types (#196) Co-authored-by: Jordan Krage <[email protected]> Co-authored-by: Ryan Tinianov <[email protected]> Co-authored-by: ilija42 <[email protected]> * Bump action to get relay renamed to common changes (#272) * . --------- Co-authored-by: Dimitris Grigoriou <[email protected]> Co-authored-by: Jordan Krage <[email protected]> Co-authored-by: Sam <[email protected]> Co-authored-by: Dmytro Haidashenko <[email protected]> Co-authored-by: Domino Valdano <[email protected]> Co-authored-by: ilija42 <[email protected]> Co-authored-by: Tate <[email protected]>
samsondav
pushed a commit
that referenced
this pull request
Jan 11, 2024
ettec
pushed a commit
that referenced
this pull request
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supports: