Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add get max size to chain reader. #218

Merged
merged 1 commit into from
Nov 6, 2023

Conversation

nolag
Copy link
Collaborator

@nolag nolag commented Nov 3, 2023

I'll need this to fully replace codec calls in median. Haven't prototyped the how yet, but seems pretty simple given it can assume there's only one level of slice and everything in it will then be fixed size :).

@reductionista reductionista force-pushed the BCF-2612-ChainReader branch 5 times, most recently from a2b4013 to 75137b1 Compare November 4, 2023 00:31
@reductionista
Copy link
Contributor

Looks like you need to add something like this to config.go:

GetMaxSize(ctx context.Context, n int, itemType string) (int, error) {
	return 0, errors.New("not used for these tests")
}

@nolag nolag force-pushed the rtinianov_sizeToo branch from 4e7c37a to db21afa Compare November 6, 2023 14:38
@reductionista reductionista merged commit db0c082 into BCF-2612-ChainReader Nov 6, 2023
8 checks passed
@reductionista reductionista deleted the rtinianov_sizeToo branch November 6, 2023 15:59
reductionista pushed a commit that referenced this pull request Nov 7, 2023
reductionista pushed a commit that referenced this pull request Dec 1, 2023
reductionista pushed a commit that referenced this pull request Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants