Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add merge and split fields utilities to be used by encoders #212

Merged
merged 1 commit into from
Nov 3, 2023

Conversation

nolag
Copy link
Collaborator

@nolag nolag commented Nov 2, 2023

No description provided.

@nolag nolag temporarily deployed to integration November 2, 2023 20:43 — with GitHub Actions Inactive
@nolag nolag temporarily deployed to integration November 2, 2023 20:43 — with GitHub Actions Inactive
pkg/utils/utils_test.go Outdated Show resolved Hide resolved
Base automatically changed from rtinianov_mapDecoder to BCF-2612-ChainReader November 3, 2023 18:07
@nolag nolag force-pushed the rtinianov_splitAndMerge branch from e1afdfc to 8324612 Compare November 3, 2023 18:08
@nolag nolag force-pushed the rtinianov_splitAndMerge branch from 8324612 to 94ddaa1 Compare November 3, 2023 18:09
@nolag nolag requested a review from jmank88 November 3, 2023 18:10
"net"
"sync"
"testing"

"github.com/stretchr/testify/assert"
"google.golang.org/grpc/test/bufconn"

"github.com/stretchr/testify/require"

"github.com/smartcontractkit/chainlink-relay/pkg/loop/internal/pb"

"context"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pre-existing, but there's a std lib context down here?

cc @chainchad seems like the linter is failing in this repo too

@jmank88 jmank88 merged commit 798f3e6 into BCF-2612-ChainReader Nov 3, 2023
5 checks passed
@jmank88 jmank88 deleted the rtinianov_splitAndMerge branch November 3, 2023 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants