CCIP-5215 Reporting sequence numbers from plugins #610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateusz-sekara
changed the title
mateusz-sekara
requested review from
winder,
asoliman92,
makramkd,
dimkouv,
0xAustinWang,
0xnogo and
b-gopalswami
makramkd
previously approved these changes
Feb 13, 2025
| } | ||
| return pickHighestSeqNr(seqNrs) |
There was a problem hiding this comment.
There was a problem hiding this comment.
Shoot, I've tried that, but it panics when slice is empty
0xnogo
previously approved these changes
Feb 13, 2025
mateusz-sekara
force-pushed
the
sequence-numbers
branch
from
c7eec55 to
9953815
Compare
|
makramkd
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.