Implement versioned logic module routing for fee-quoter #604
Conversation
| pub trait Public { | ||
| fn get_fee<'info>( | ||
| &self, | ||
| ctx: Context<'_, '_, 'info, 'info, GetFee>, | ||
| dest_chain_selector: u64, | ||
| message: SVM2AnyMessage, | ||
| ) -> Result<GetFeeResult>; | ||
| } | ||
|
|
||
| pub trait Prices { |
There was a problem hiding this comment.
I'm not sure about the trait names; I think they could be a bit more expressive. PublicFeeGetter, UpdateablePrices maybe? As it stands it can be difficult to tell what functionality is supported by just reading the trait.
There was a problem hiding this comment.
They correlate 1:1 with module names. I'm up for renaming them if you prefer, but then I would also rename files & modules everywhere to keep them aligned. I'll merge as-is and do any renaming in a separate PR after we've chatted more offline 👍
There was a problem hiding this comment.
Sure, if the semantics are "the trait refers to who can call this", Public and Admin make sense, though I'd still like a clarifying comment atop the trait itself. However, Prices stands out among the three then. Maybe it just needs to be PriceUpdater so it also responds to the question of who can call this.
|
We created versioned modules with upgradeable business logic in #414 and subsequent PRs. This new PR implements for FeeQuoter the routing layer between versions of said module.
Note for reviewers: make sure to
hide whitespacesin GitHub when reviewing this to reduce some of the noise.