-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Onramp upgrade & rollback flows [NONEVM-1297] #603
Conversation
@@ -81,6 +86,44 @@ pub fn update_dest_chain_config( | |||
Ok(()) | |||
} | |||
|
|||
pub fn bump_ccip_version_for_dest_chain( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@RensR if you want to review, this is the implementation of the onramp upgrade/rollback which we talked about and how to handle the sequence number accordingly. Just looking at this file is enough I think, no need to worry about the rest.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just two minor points on comments/clarity.
chains/solana/contracts/programs/ccip-router/src/instructions/v1/admin.rs
Outdated
Show resolved
Hide resolved
…o tobi/onramp-upgrade-rollback
|
This PR supports emulating a CCIP minor version bump on the onramp. The bump is done per-lane (so, per dest-chain for the onramp). To do the bump, the owner should:
Then, to rollback, the owner should:
Caveats: