Allow only price aggregator contract to have multiple bindings [CCIP-4781] #426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… contracts should only have one instance at any single time.
asoliman92
changed the title
asoliman92
requested review from
winder,
makramkd,
dimkouv,
mateusz-sekara,
0xAustinWang,
0xnogo and
b-gopalswami
makramkd
reviewed
Jan 9, 2025
makramkd
previously approved these changes
Jan 9, 2025
| } else { | ||
| if len(e.contractBindingsByName[binding.Name]) > 0 { | ||
| // Unbind the previous binding | ||
| err := e.reader.Unbind(ctx, []types.BoundContract{e.contractBindingsByName[binding.Name][0].Binding}) |
There was a problem hiding this comment.
Double checking - are we certain there's only one other binding in this situation?
There was a problem hiding this comment.
Because of the current condition yes there should only be one binding.
There was a problem hiding this comment.
There could be more if the extended reader was created with a reader that already had bound contracts. But that would just mean there are some dangling bindings, our discovery code would work fine because error checking is done using the contractBindingsByName list.
makramkd
approved these changes
Jan 9, 2025
|
winder
reviewed
Jan 9, 2025
Comment on lines
+271
to
+275
| if e.multiBindAllowed[binding.Name] { | ||
| e.contractBindingsByName[binding.Name] = append(e.contractBindingsByName[binding.Name], ExtendedBoundContract{ | ||
| BoundAt: time.Now(), | ||
| Binding: binding, | ||
| }) |
There was a problem hiding this comment.
style nit: I would be tempted to rewrite this to avoid the else. Something like
// unbind previous contract if needed
if len(e.contractBindingsByName[binding.Name]) > 0 && e.multiBindAllowed[binding.Name] {
e.reader.Unbind(...)
e.contractBindingsByName[binding.Name] = nil
}
// existing logic here
}
winder
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow only price aggregator contract to have multiple bindings, othe contracts should only have one instance at any single time.
core ref: 843e228fba3c5264d34fb5bc2bd972f1576057d8
Core PR: smartcontractkit/chainlink#15854