CCIP-3713 Filtering by the 3rd word in USDC Reader #221
Conversation
mateusz-sekara
changed the title
mateusz-sekara
requested review from
winder,
rstout,
asoliman92,
makramkd,
dimkouv and
0xnogo
mateusz-sekara
changed the title
pkg/reader/usdc_reader.go
Outdated
| for _, id := range eventIDs { | ||
| eventFilter = append( | ||
| eventFilter, | ||
| query.Comparator(consts.EventFilterCCIPMessageSent, |
There was a problem hiding this comment.
Name for value filter primitive shouldn't be mixed up with the key name. I would prefer if the comparator was called something like MessageValue. You are essentially filtering for values contained within the EventFilterCCIPMessageSent entity
There was a problem hiding this comment.
I don't follow. Is it about the name of the const (consts.EventFilterCCIPMessageSent) or its value? What do you suggest instead?
Name for value filter primitive shouldn't be mixed up with the key name.
I think it's different, isn't it?
Query key is consts.EventNameCCTPMessageSent, but comparator is consts.EventFilterCCIPMessageSent, am I missing sth?
There was a problem hiding this comment.
Sry I misread that multiple times while looking at the code. Still, wouldn't constants like this: consts.CCIPMessageSentValue and for the event itself consts.CCIPMessageSent make more sense?
There was a problem hiding this comment.
Trying to follow existing patters in naming, so I've renamed to
consts.CCTPMessageSentValue // for the comparator
consts.EventNameCCTPMessageSent // kept existing for the event
|
No description provided.