Add support for Samsung AR18TGHQASINSE, Daikin FTV35CXV & FTKQ35UVM4 + add support for on_once (toggle) #884
Conversation
|
I hope this gets merged soon! Plenty of ACs need the "on_once" logic to be usable. |
| @@ -323,6 +324,12 @@ async def async_set_hvac_mode(self, hvac_mode): | |||
| if not hvac_mode == HVAC_MODE_OFF: | |||
| self._last_on_operation = hvac_mode | |||
|
|
|||
| # Turn AC on if it requires a pre-command | |||
| if self._previous_hvac_mode == HVAC_MODE_OFF: # only if it's previously off | |||
There was a problem hiding this comment.
It seems there's a bug here. self._previous_hvac_mode is not kept up to date when changing HVAC mode. Therefore, when changing modes the on_once is triggered in between mode changes.
To fix it, what i've done is added:
self._previous_hvac_mode = self._hvac_mode
right before it makes the actual change to self._hvac_mode
|
This would be awesome! Great work! |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Really hope it gets merged too! |
|
Any news on this? |
|
So this was closed without merging. Does that mean the toggle on_once functionality is available in some other way? |
I've also added the necessary support for toggle AC's (required for the Daikin FTV35CXV).
This also fixes #573