Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add presets to climate #709

Closed
wants to merge 2 commits into from

Conversation

Zen3515
Copy link

@Zen3515 Zen3515 commented Aug 19, 2021

The main change is in climate.py where I added preset support.

To use preset you must add key "presets" into code.json, if the old code without "presets" key were use, it'll work like normal.

"presets": ["none", "eco"],

Then inside "commands" key, you must add the mode beside none here before operation mode.

"commands": {
    "off": "...",
    "cool--operation-mode-cool-when-preset-none": {
        "auto": {},
        "low": {},
    },
    "eco--presets-eco": {
        "cool--operation-mode-cool-when-preset-eco": {
            "auto": {},
            "low": {},
        },
    }
}

Ignore from -- I added that to add a comment.

You can look at the finished new code file at another pull request from me that edit 1162.json

I use home assistant dev container to edit the code, it just formats the file that I press save.
If you want me to just add the change, I'm willing to help.

@Zen3515
Copy link
Author

Zen3515 commented Aug 19, 2021

You might wanted to look at json from #710

@vassilis-panos
Copy link
Member

I'm on summer vacation right now. It is an interesting approach.

@Zen3515 Zen3515 force-pushed the support-preset-modes branch from 24aff9e to 110ac02 Compare August 19, 2021 15:44
@stale
Copy link

stale bot commented Oct 30, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added stale and removed stale labels Oct 30, 2021
@Zen3515 Zen3515 force-pushed the support-preset-modes branch from 9657c7d to 141692a Compare November 20, 2021 14:30
@Zen3515
Copy link
Author

Zen3515 commented Nov 20, 2021

@vassilis-panos I've updated to the current version with master. Would you merge this branch? what do you want me to do next?

@Zen3515 Zen3515 force-pushed the support-preset-modes branch from 141692a to b8961bb Compare January 25, 2022 13:47
@stale
Copy link

stale bot commented Apr 16, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Apr 16, 2022
@stale stale bot closed this Apr 25, 2022
@stale stale bot removed the stale label Apr 26, 2022
@stale
Copy link

stale bot commented Jun 12, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jun 12, 2022
@stale stale bot closed this Jul 10, 2022
@Zen3515
Copy link
Author

Zen3515 commented Jan 28, 2024

@vassilis-panos would you like to revive this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants