-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Live Code Updates #394
Open
smarr
wants to merge
20
commits into
smarr:dev
Choose a base branch
from
Marmat21:liveupdates
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Live Code Updates #394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… invokable of new module
Updating now works unless object is reinitialized
New slots with the same name of old slots are pushed in the old class and they are mapped to the same location of old slots. For this reason, we don’t need to place the old slots in the mixinBuilder anymore.
…frame. restart is still not same behaviour as ST (reenter instead of redispatch)
…t already have a value. Some slots still stay duplicated but it seems to work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Marmat21 I hope it's ok for you for me to document this branch based on your notes:
"""
Main change: I added support in SOMns for updating classes.
To this extent, I had to touch several parts of the mixindefinition, as well as invalidate assumptions and caches so that the new newly complied module would be used.
In short, it works as follows:
This is because recompiling a module not only recompiles methods, but also recompiles slots, which leads to new methods referencing new slots. Thus, both methods (aka dispatchables) and slots have to be set from A’ into A.
In total, I added two commands that the FrontEndConnector now understands: UpdateClass and RestartFrame.
The first one does as specified above, the second one instructs Truffle to restart the execution from a certain frame in the stack by re-entering it.
Note that the branch before the merge refers to an older version of Carmen’s branch before the rebase of Stefan. The merged version linked above does include the rebase of Stefan and passes the CI tests as of 16/12/2022.
"""