guarantee final pipeline #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nithyashree675
force-pushed
the
guarantee_final_pipeline
branch
8 times, most recently
from
1ca2c4f to
b5f0dad
Compare
nithyashree675
force-pushed
the
guarantee_final_pipeline
branch
from
b5f0dad to
7ab1836
Compare
nithyashree675
force-pushed
the
guarantee_final_pipeline
branch
2 times, most recently
from
2d5350c to
3e927f5
Compare
nithyashree675
force-pushed
the
guarantee_final_pipeline
branch
from
3e927f5 to
77a2043
Compare
andreipehas
approved these changes
May 10, 2022
mattiasb
reviewed
Jan 17, 2023
| log.info('Commit id to merge %r (into: %r)', actual_sha, target_sha) | ||
| if _updated_sha == actual_sha and self._options.guarantee_final_pipeline: | ||
| log.info('No commits on target branch to fuse, triggering pipeline...') | ||
| merge_request.comment("jenkins retry") |
There was a problem hiding this comment.
How does this guarantee that the final pipeline is run? It seems especially suspicious to add a comment saying "jenkins retry" here. Is that some internal smarkets CI stuff that's leaking out here? :)
There was a problem hiding this comment.
shouldn't this be a merge_request_pipeline_trigger call instead ? Maybe I'm missing something ...
There was a problem hiding this comment.
This is essentially what was done in the community fork in this MR: https://gitlab.com/marge-org/marge-bot/-/merge_requests/387.
This upstream project is no longer maintained as far as we can tell.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #341