Use default branch instead of master #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snim2
force-pushed
the
default-branch-may-not-be-master
branch
from
425c847 to
552dcfe
Compare
snim2
changed the title
mujx
reviewed
Oct 12, 2021
| @@ -10,6 +10,7 @@ | |||
| 'path_with_namespace': 'cool/project', | |||
| 'ssh_url_to_repo': 'ssh://blah.com/cool/project.git', | |||
| 'merge_requests_enabled': True, | |||
| 'default_branch': 'master', | |||
There was a problem hiding this comment.
Can't we use here the env variable CI_DEFAULT_BRANCH which is already provided by gitlab?
There was a problem hiding this comment.
It's provided both by the env var and by the API so potentially we could do either, but the existing code seems to prefer the API over env vars, so I stuck with that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #324