Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add argument to disable fast forwarding of batch merges #256

Merged
merged 2 commits into from
Apr 28, 2020

Conversation

mathyoudawson
Copy link
Contributor

Previously when merging batches fast forwarding is enabled. This is
problematic when reverting changes that have been fast forwarded as
you then have to revert each individual commit.

This commit adds an argument to disable the fast forward merging of
batches.

Fixes #255

Previously when merging batches fast forwarding is enabled. This is
problematic when reverting changes that have been fast forwarded as
you then have to revert each individual commit.

This commit adds an argument to disable the fast forward merging of
batches.
@mathyoudawson mathyoudawson force-pushed the optionally-ff-batches branch from d1636a5 to dd8824c Compare April 26, 2020 09:00
@mathyoudawson mathyoudawson changed the title Add arguement to disable fast forwarding of batch merges Add argument to disable fast forwarding of batch merges Apr 26, 2020
README.md Outdated Show resolved Hide resolved
marge/batch_job.py Outdated Show resolved Hide resolved
marge/batch_job.py Outdated Show resolved Hide resolved
@mathyoudawson
Copy link
Contributor Author

Hi @RobertKirk,
Apologies for the basic formatting errors - I have fixed them in the latest fixup commit.

@RobertKirk
Copy link
Contributor

No worries. Looks good now, will squash and merge.

@RobertKirk RobertKirk merged commit 38b9e51 into smarkets:master Apr 28, 2020
@mathyoudawson mathyoudawson deleted the optionally-ff-batches branch April 28, 2020 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When merging batches, fast fordwarding is enabled
2 participants