fix: Return page width and height from document #700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitormattos
changed the title
Some documents could have pages without MediaBox, at this case we need to get the MediaBox from document and not from a specific page. Signed-off-by: Vitor Mattos <[email protected]>
vitormattos
force-pushed
the
fix/improve-documentation
branch
from
bf8a9af to
589a3c7
Compare
Prevent the follow error: ``` ERROR: InvalidPassByReference - Parameter 1 of reset expects a variable (see https://psalm.dev/102) $details = reset($pdf->getObjectsByType('Pages'))->getHeader()->getDetails(); ``` Signed-off-by: Vitor Mattos <[email protected]>
|
Thank you, good addition to the documentation @vitormattos |
k00ni
reviewed
Apr 9, 2024
Co-authored-by: Konrad Abicht <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of pull request
About
Some documents could have pages without MediaBox, at this case we need to get the MediaBox from document and not from a specific page.