Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make horizontal offset configurable #505

Merged
merged 4 commits into from
Jan 17, 2022
Merged

Conversation

rubenvanerk
Copy link
Contributor

Solves the issue as described in this comment: #193 (comment)

Copy link
Collaborator

@k00ni k00ni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

src/Smalot/PdfParser/Config.php Show resolved Hide resolved
src/Smalot/PdfParser/Config.php Outdated Show resolved Hide resolved
src/Smalot/PdfParser/PDFObject.php Show resolved Hide resolved
@k00ni
Copy link
Collaborator

k00ni commented Jan 10, 2022

Does this fix #193 and #72?

This was linked to issues Jan 11, 2022
@k00ni k00ni mentioned this pull request Jan 12, 2022
@rubenvanerk rubenvanerk requested a review from k00ni January 16, 2022 14:47
@k00ni k00ni removed the needs work label Jan 17, 2022
Copy link
Collaborator

@k00ni k00ni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your changes, it looks good to me.

If you have the time can you tell me if this PR fixes #193 and #72?

Any remarks @j0k3r?

@rubenvanerk
Copy link
Contributor Author

As I don't have access to the pdf's in those issues, I can't say for sure. But I think it does.

Since I used the pdf of #494, I can say that it fixes that issue.

@k00ni k00ni merged commit ddb14ae into smalot:master Jan 17, 2022
@k00ni k00ni mentioned this pull request Feb 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Random spaces in text Inserting white spaces beetween letters
3 participants