Add support for Reversed Chars instruction in BMC blocs #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k00ni
approved these changes
Mar 10, 2021
There was a problem hiding this comment.
Looks good to me, but I would wait with a merge until @bredisvictor responded in #398.
k00ni
requested changes
Mar 10, 2021
There was a problem hiding this comment.
Hebrew text displayed in reverse #398 (comment) should be solved before a merge.We should write tests for each PDF provided in Hebrew text displayed in reverse #398
2 tasks
|
@smalot can I help you here? |
|
@smalot do you plan to finish this soon? As of now it doesn't fix #398 (ref: #398 (comment)) |
|
I removed fix-reference to #398, because there are still problems left (see comment above). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.