-
Notifications
You must be signed in to change notification settings - Fork 539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port atoum tests to PHPUnit #300
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job!
I won't review all the changes from Atoum to PHPUnit, to much stuff to check.
I trust you.
You should add the scrutinizer badge to the README.
I'm wondering why does Scrutinizer doesn't show up along with Travis build 🤔 |
I don't know. But in case you are interested in the latest results: https://scrutinizer-ci.com/g/smalot/pdfparser/?branch=feature/switch-to-phpunit |
I am still not sure when it runs code coverage. Even if you have |
Good catch! I just saw, that i used a Docker container without xdebug installed. OK anything left or can i merge it? |
Looks great, you can squash your commits 👍 |
This pull request replaces atoum tests with PHPUnit tests.
We have code coverage now (via scrutinizer):
Reasons for this pull request
Changes
test/
tests/
use Class
insteadParser
. That makes tests more decoupled from the actual class constructor and in case it changes, only 1 place has to be adapted.TODOs:
prepare for coveralls?- use https://scrutinizer-ci.com/docs/build/code_coverage instead