-
Notifications
You must be signed in to change notification settings - Fork 541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix illegal encoding for MacRomanEncoding #238
Conversation
Port across smalot#238
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @daneren2005, can you ... (posted list outdated, see the latest at the bottom)
I made my own package because I gave up. I don't intend on spending any more time on this. If anyone else wants to spend the time they are more then welcome. |
Hello @daneren2005, no problem, thank your for your efforts though. I will re-open this PR, maybe we can finish it another time. If someone else wants to help, this is what is left to do here:
Name change in |
With Mac in the from encoding, would get the following error: `mb_convert_encoding(): Illegal character encoding specified`. Fixes smalot#229
I cleaned up the PR. |
This file reproduces the problem. |
I created the branch pr/238 here and tried the PDF given by @fbett. The PDFParser is fine in PHP 5.6 - 7.4, but raises an error in PHP 8.0. He complains:
https://travis-ci.org/github/smalot/pdfparser/jobs/701562931#L257 As far as i can tell no one changed related code, so why is the error gone before PHP 8.0? With the fix from daneren2005 all tests run without an error on all PHP versions. 👍 https://travis-ci.org/github/smalot/pdfparser/builds/701564912 Left to do:
Any objections? |
Closed, replacement will be merged instead: #313 Thank you for your effort everyone! |
* try fix from @daneren2005 (from #238) to fix failing test in PHP 8.0
With Mac in the from encoding, would get the following error:
mb_convert_encoding(): Illegal character encoding specified
. Fixes #229