Improve time functions #539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR changes name of the toTime template function to formatTime and adds toTime and mustToTime, which parse a string and convert it to a time, and toLayout that converts strings like time.RFC3339 to the actual layout string.
hslatman
reviewed
Jul 2, 2024
maraino
force-pushed
the
mariano/timeFunctions
branch
2 times, most recently
from
735b6bf to
edbd11e
Compare
maraino
force-pushed
the
mariano/timeFunctions
branch
from
edbd11e to
ca6ad2a
Compare
hslatman
reviewed
Jul 3, 2024
internal/templates/funcmap.go
Outdated
| m["toTime"] = toTime | ||
| m["parseTime"] = parseTime | ||
| m["mustParseTime"] = mustParseTime | ||
| m["toLayout"] = toLayout |
There was a problem hiding this comment.
The functionality of the function is specific to times/dates, and the other new functions have this in their name. Maybe it should be called toTimeLayout / toDateLayout (or support both)?
There was a problem hiding this comment.
Could be toTimeLayout "RFC8222"
instead of toLayout "time.RFC8222"?
internal/templates/funcmap.go
Outdated
Comment on lines
14
to
15
| // functions "formatTime", "toTime", "mustToTime", and changes the function | ||
| // "fail". |
There was a problem hiding this comment.
Might want to add toLayout (or its updated name(s)) here
internal/templates/funcmap.go
Outdated
| // time using RFC3339. The functions "parseTime" and "mustParseTime" parse a | ||
| // string and return the time.Time it represents. The "toLayout" function | ||
| // converts strings like "time.RFC3339" or "time.UnixDate" to the actual layout | ||
| // represented by the Go constant with the same nameß. The "fail" function sets |
There was a problem hiding this comment.
Suggested change
| // represented by the Go constant with the same nameß. The "fail" function sets | |
| // represented by the Go constant with the same name. The "fail" function sets |
hslatman
reviewed
Jul 3, 2024
internal/templates/funcmap.go
Outdated
| return time.RFC3339 | ||
| case "RFC3339Nano": | ||
| return time.RFC3339Nano | ||
| // From the ones bellow, only time.DateTime will parse a complete date. |
There was a problem hiding this comment.
Suggested change
| // From the ones bellow, only time.DateTime will parse a complete date. | |
| // From the ones below, only time.DateTime will parse a complete date. |
internal/templates/funcmap.go
Outdated
Comment on lines
116
to
117
| switch strings.TrimPrefix(fmt, "time.") { | ||
| case "Layout": |
There was a problem hiding this comment.
Just for convenience for the user, we could allow any case, but up to you
hslatman
approved these changes
Jul 3, 2024
maraino
added a commit
to smallstep/certificates
that referenced
this pull request
Jul 3, 2024
This commit upgrades go.step.sm/crypto that includes the template functions added with smallstep/crypto#539
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR improves the functions added in #534 with some usability changes.
toTime 1719970524returns atime.Timein UTC from a time or a Unix epoch.formatTime (now): from a time or Unix epoch returns a time string using RFC3339 format UTC.parseTimeandmustParseTime:parseTime: returns the currenttime.Timein UTC.parseTime "2024-07-03T01:30:39Z": parses the given time using RFC3339.parseTime "time.UnixDate" "Tue Jul 2 18:31:04 PDT 2024": parses a time using a given format.parseTime "time.UnixDate" "Tue Jul 2 18:31:04 PDT 2024" "America/Los_Angeles": parses a time with the given format and time zone.toTimeLayoutreturns a layout format from the given name.toTimeLayout "RFC3339"returns2006-01-02T15:04:05Z07:00toTimeLayout "time.UnixDate"returnsMon Jan _2 15:04:05 MST 2006