Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DOCKER_STEPCA_INIT_PASSWORD_FILE variable for Docker secrets #1384

Merged
merged 1 commit into from
May 10, 2023

Conversation

francescocapuano
Copy link

Add the management of the DOCKER_STEPCA_INIT_PASSWORD_FILE variable. over DOCKER_STEPCA_INIT_PASSWORD. If both are used only DOCKER_STEPCA_INIT_PASSWORD_FILE will be used.

Name of feature:

Add DOCKER_STEPCA_INIT_PASSWORD_FILE variable for Docker secrets

Pain or issue this feature alleviates:

Allow the possibility to use Docker Secrets for step-ca init password

Why is this important to the project (if not answered above):

This allow to use a predefined password with having to use enviromental variables

Is there documentation on how to use this feature? If so, where?

I can do it, but I don't know where in this repo

In what environments or workflows is this feature supported?

Docker

In what environments or workflows is this feature explicitly NOT supported (if any)?

Supporting links/other PRs/issues:

💔Thank you!

@CLAassistant
Copy link

CLAassistant commented May 10, 2023

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the needs triage Waiting for discussion / prioritization by team label May 10, 2023
Add the management of the DOCKER_STEPCA_INIT_PASSWORD_FILE variable.  over DOCKER_STEPCA_INIT_PASSWORD.
If both are used only DOCKER_STEPCA_INIT_PASSWORD_FILE will be used.
Copy link
Contributor

@tashian tashian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @francescocapuano for this contribution.
I can update the docs on Docker Hub to reflect this variable.

@hslatman hslatman added this to the v0.24.2 milestone May 10, 2023
@hslatman
Copy link
Member

Thank you, @francescocapuano 😄

@hslatman hslatman merged commit b96831e into smallstep:master May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs triage Waiting for discussion / prioritization by team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants