Fix the synchronization protocol of the InternalChannelRegistry #2212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switched to CHM and CopyOnWriteArrayList instead of synchronized methods. Based on this initial commit: whitingjr@f9c5def Co-authored-by: Jeremy Whiting <[email protected]>
|
@whitingjr are you ok with this one? |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2212 +/- ##
============================================
- Coverage 77.76% 77.74% -0.03%
- Complexity 3694 3731 +37
============================================
Files 301 311 +10
Lines 12307 12443 +136
Branches 1570 1579 +9
============================================
+ Hits 9571 9674 +103
- Misses 2020 2046 +26
- Partials 716 723 +7
|
|
@cescoffier yes that is fine. ty |
ozangunalp
approved these changes
Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2207:
Based on this initial commit:
whitingjr@f9c5def