Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kafka client.id prefix attribute #1909

Merged
merged 1 commit into from
Sep 21, 2022

Conversation

ozangunalp
Copy link
Collaborator

  • Adding an optional incoming/outgoing channel attribute client-id-prefix.
  • If no client.id is configured, generate it using the channel name, using the default prefix "kafka-consumer-" (current behaviour)
  • If a client.id is configured, add the prefix with default value "" (empty)
  • For consumer's currently appended suffix per partition consumer continues to work.

@codecov-commenter
Copy link

codecov-commenter commented Sep 21, 2022

Codecov Report

Merging #1909 (661d39f) into main (13fd68e) will decrease coverage by 0.08%.
The diff coverage is 100.00%.

❗ Current head 661d39f differs from pull request most recent head aa27211. Consider uploading reports for the commit aa27211 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1909      +/-   ##
============================================
- Coverage     77.66%   77.58%   -0.09%     
- Complexity     3315     3318       +3     
============================================
  Files           285      285              
  Lines         11115    11117       +2     
  Branches       1411     1419       +8     
============================================
- Hits           8633     8625       -8     
- Misses         1814     1827      +13     
+ Partials        668      665       -3     
Impacted Files Coverage Δ
...llrye/reactive/messaging/kafka/KafkaConnector.java 89.47% <ø> (ø)
...ve/messaging/kafka/impl/ReactiveKafkaConsumer.java 82.75% <100.00%> (-1.07%) ⬇️
...ve/messaging/kafka/impl/ReactiveKafkaProducer.java 72.81% <100.00%> (+0.81%) ⬆️
...reactive/messaging/gcp/pubsub/PubSubConnector.java 33.76% <0.00%> (-7.80%) ⬇️
...a/io/smallrye/reactive/messaging/mqtt/Clients.java 88.46% <0.00%> (-7.70%) ⬇️
...e/reactive/messaging/gcp/pubsub/PubSubManager.java 41.57% <0.00%> (-5.62%) ⬇️
...ye/reactive/messaging/gcp/pubsub/PubSubConfig.java 63.15% <0.00%> (-2.64%) ⬇️
...e/messaging/rabbitmq/IncomingRabbitMQMetadata.java 53.84% <0.00%> (-2.57%) ⬇️
...ctive/messaging/rabbitmq/RabbitMQClientHelper.java 56.33% <0.00%> (-1.41%) ⬇️
...tive/messaging/rabbitmq/RabbitMQMessageSender.java 53.65% <0.00%> (-1.22%) ⬇️
... and 12 more

@cescoffier cescoffier merged commit 1590f1c into smallrye:main Sep 21, 2022
@mrickly
Copy link

mrickly commented Sep 21, 2022

@ozangunalp : Thank you for your implementation!

@ozangunalp ozangunalp added this to the 3.20.0 milestone Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants