Make some ModelIO instance fields constants #2050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The initialisation of these two fields showed up in performance testing, since we create quite a few ModelIO-based objects when parsing or serializing and SmallRyeOASModels populates a large map in its constructor.
|
MikeEdgar
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The initialization of these two fields showed up in performance testing, since we create quite a few ModelIO-based objects when parsing or serializing and
SmallRyeOASModelspopulates a large map in its constructor.An alternative would be to make
SmallRyeOASModelsa singleton, but since this is the only place it's used, making the field a constant should fix the performance issue.