Support identifier field in licence objects #1834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeEdgar
reviewed
May 16, 2024
There was a problem hiding this comment.
@benjamin-confino I think this needs to be rebased, then it should be good.
benjamin-confino
force-pushed
the
licence-reference
branch
from
ce60d53 to
24ec437
Compare
benjamin-confino
force-pushed
the
licence-reference
branch
from
24ec437 to
33cc40e
Compare
MikeEdgar
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This keeps smallrye up to date with the spec change implemented here: eclipse/microprofile-open-api#436
And this PR depends on eclipse/microprofile-open-api#611
I investigated to see if [PathItem](https://spec.openapis.org/oas/v3.1.0.html#path-item-object] parameters had any code to emit a warning or exception if the constraint is violated and could not find one so I did not add anything to enforce the exclusivity of URL and Identifier. Let me know if I missed something.
For the test I used the maven plugin test to ensure one plugin tests each of the URL and identifier without violating the constraint, let me know if you'd prefer both test both