-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused outer queue in flatmap subscriber #975
Conversation
4ae116e
to
ade72b8
Compare
Codecov Report
@@ Coverage Diff @@
## main #975 +/- ##
============================================
+ Coverage 88.97% 89.25% +0.28%
- Complexity 3137 3141 +4
============================================
Files 412 412
Lines 12594 12566 -28
Branches 1595 1586 -9
============================================
+ Hits 11205 11216 +11
+ Misses 734 710 -24
+ Partials 655 640 -15
|
ade72b8
to
3392725
Compare
I've looked at the code and it seems correct. I believe I dropped the queue a few months/years ago without removing the code using that queue. |
@jponge if you could have a look just in case I miss something obvious. |
On my radar |
Tests pass and I think we have good coverage for the various execution paths here, so I think it's correct. |
@ozangunalp Can you please rebase? |
3392725
to
a9f882b
Compare
@jponge rebased |
|
ahah wait at least until the next PR :) |
Ah @ozangunalp we need your commits to be GnuPG-signed |
Remove the mainqueuesupplier in flatmap subscriber
Head branch was pushed to by a user without write access
a9f882b
to
17ff781
Compare
No description provided.