Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused outer queue in flatmap subscriber #975

Merged
merged 1 commit into from
Jul 15, 2022

Conversation

ozangunalp
Copy link
Collaborator

No description provided.

@ozangunalp ozangunalp force-pushed the remove_unused_flatmap_queue branch from 4ae116e to ade72b8 Compare July 4, 2022 10:34
@codecov
Copy link

codecov bot commented Jul 4, 2022

Codecov Report

Merging #975 (a9f882b) into main (8098078) will increase coverage by 0.28%.
The diff coverage is 100.00%.

❗ Current head a9f882b differs from pull request most recent head 17ff781. Consider uploading reports for the commit 17ff781 to get more accurate results

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #975      +/-   ##
============================================
+ Coverage     88.97%   89.25%   +0.28%     
- Complexity     3137     3141       +4     
============================================
  Files           412      412              
  Lines         12594    12566      -28     
  Branches       1595     1586       -9     
============================================
+ Hits          11205    11216      +11     
+ Misses          734      710      -24     
+ Partials        655      640      -15     
Impacted Files Coverage Δ
...mallrye/mutiny/operators/multi/MultiFlatMapOp.java 90.69% <100.00%> (+5.59%) ⬆️
.../io/smallrye/mutiny/helpers/queues/DrainUtils.java 77.77% <0.00%> (-4.45%) ⬇️
...lrye/mutiny/subscription/SerializedSubscriber.java 85.32% <0.00%> (-2.76%) ⬇️
...perators/multi/processors/SerializedProcessor.java 89.10% <0.00%> (ø)
...tiny/operators/multi/MultiBufferWithTimeoutOp.java 75.63% <0.00%> (+0.84%) ⬆️
...a/io/smallrye/mutiny/helpers/BlockingIterable.java 87.03% <0.00%> (+0.92%) ⬆️
...erators/multi/builders/SerializedMultiEmitter.java 80.48% <0.00%> (+1.21%) ⬆️
...io/smallrye/mutiny/operators/uni/UniMemoizeOp.java 93.20% <0.00%> (+1.94%) ⬆️
...ny/operators/uni/builders/UniCreateFromFuture.java 91.80% <0.00%> (+3.27%) ⬆️
... and 4 more

@ozangunalp ozangunalp force-pushed the remove_unused_flatmap_queue branch from ade72b8 to 3392725 Compare July 4, 2022 10:55
@cescoffier
Copy link
Contributor

I've looked at the code and it seems correct. I believe I dropped the queue a few months/years ago without removing the code using that queue.

@cescoffier
Copy link
Contributor

@jponge if you could have a look just in case I miss something obvious.

@jponge
Copy link
Member

jponge commented Jul 7, 2022

On my radar

@jponge
Copy link
Member

jponge commented Jul 7, 2022

Tests pass and I think we have good coverage for the various execution paths here, so I think it's correct.

@ozangunalp ozangunalp marked this pull request as ready for review July 7, 2022 12:02
@jponge jponge added this to the 2.0.0 milestone Jul 13, 2022
@jponge
Copy link
Member

jponge commented Jul 15, 2022

@ozangunalp Can you please rebase?

@ozangunalp ozangunalp force-pushed the remove_unused_flatmap_queue branch from 3392725 to a9f882b Compare July 15, 2022 07:41
@ozangunalp
Copy link
Collaborator Author

@jponge rebased

@jponge jponge added the technical-debt Technical debt reduction label Jul 15, 2022
@jponge jponge enabled auto-merge July 15, 2022 07:52
@jponge
Copy link
Member

jponge commented Jul 15, 2022

I hereby declare @ozangunalp a drain-loop expert.

@ozangunalp
Copy link
Collaborator Author

ahah wait at least until the next PR :)

@jponge
Copy link
Member

jponge commented Jul 15, 2022

Ah @ozangunalp we need your commits to be GnuPG-signed

Remove the mainqueuesupplier in flatmap subscriber
auto-merge was automatically disabled July 15, 2022 08:47

Head branch was pushed to by a user without write access

@ozangunalp ozangunalp force-pushed the remove_unused_flatmap_queue branch from a9f882b to 17ff781 Compare July 15, 2022 08:47
@jponge jponge enabled auto-merge July 15, 2022 09:04
@jponge jponge merged commit e67d10d into smallrye:main Jul 15, 2022
@jponge jponge modified the milestones: 2.0.0, 2.0.0-milestone1 Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
technical-debt Technical debt reduction
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants