Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid wrapping scheduled executors #955

Merged
merged 1 commit into from
Jun 17, 2022

Conversation

jponge
Copy link
Member

@jponge jponge commented Jun 17, 2022

This is part of a larger bug fix in Quarkus, see quarkusio/quarkus#25818

This is part of a larger bug fix in Quarkus, see quarkusio/quarkus#25818
@jponge jponge added this to the 2.0.0 milestone Jun 17, 2022
@jponge jponge added bug Something isn't working backport PR that shall be back-ported labels Jun 17, 2022
@codecov
Copy link

codecov bot commented Jun 17, 2022

Codecov Report

Merging #955 (d8a08af) into main (af0811d) will increase coverage by 0.15%.
The diff coverage is 0.00%.

❗ Current head d8a08af differs from pull request most recent head cceccf5. Consider uploading reports for the commit cceccf5 to get more accurate results

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #955      +/-   ##
============================================
+ Coverage     89.00%   89.15%   +0.15%     
- Complexity     3132     3139       +7     
============================================
  Files           412      412              
  Lines         12576    12576              
  Branches       1592     1593       +1     
============================================
+ Hits          11193    11212      +19     
+ Misses          728      716      -12     
+ Partials        655      648       -7     
Impacted Files Coverage Δ
...smallrye/mutiny/infrastructure/Infrastructure.java 67.20% <0.00%> (-0.54%) ⬇️
...main/kotlin/io/smallrye/mutiny/coroutines/Multi.kt 76.19% <0.00%> (-4.77%) ⬇️
...mallrye/mutiny/operators/multi/MultiFlatMapOp.java 84.19% <0.00%> (-0.92%) ⬇️
...tiny/operators/multi/MultiBufferWithTimeoutOp.java 73.10% <0.00%> (-0.85%) ⬇️
...allrye/mutiny/operators/uni/UniAndCombination.java 91.17% <0.00%> (+0.98%) ⬆️
...subscription/SwitchableSubscriptionSubscriber.java 97.60% <0.00%> (+1.59%) ⬆️
...java/io/smallrye/mutiny/helpers/Subscriptions.java 80.66% <0.00%> (+1.65%) ⬆️
...io/smallrye/mutiny/operators/uni/UniMemoizeOp.java 93.20% <0.00%> (+1.94%) ⬆️
...lrye/mutiny/subscription/SerializedSubscriber.java 88.07% <0.00%> (+2.75%) ⬆️
...perators/multi/processors/SerializedProcessor.java 85.14% <0.00%> (+2.97%) ⬆️
... and 3 more

Copy link
Contributor

@cescoffier cescoffier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smart 🤪

@cescoffier cescoffier merged commit 8fc5c3f into main Jun 17, 2022
@cescoffier cescoffier deleted the bug/avoid-wrapping-scheduled-executors branch June 17, 2022 17:43
@cescoffier
Copy link
Contributor

We may want to backport to 1.x

@jponge
Copy link
Member Author

jponge commented Jun 17, 2022 via email

@jponge jponge mentioned this pull request Jun 18, 2022
jponge added a commit to jponge/quarkus that referenced this pull request Jun 20, 2022
This is part of a coordinated fix across Quarkus and Mutiny where scheduler wrapping would cause Vert.x context propagation not to be done.

See smallrye/smallrye-mutiny#955

Fixes quarkusio#25818
jponge added a commit to jponge/quarkus that referenced this pull request Jun 20, 2022
This is part of a coordinated fix across Quarkus and Mutiny where scheduler wrapping would cause Vert.x context propagation not to be done.

See smallrye/smallrye-mutiny#955

Fixes quarkusio#25818
jponge added a commit to jponge/quarkus that referenced this pull request Jun 20, 2022
This is part of a coordinated fix across Quarkus and Mutiny where scheduler wrapping would cause Vert.x context propagation not to be done.

See smallrye/smallrye-mutiny#955

Fixes quarkusio#25818
jponge added a commit to jponge/quarkus that referenced this pull request Jun 21, 2022
…hedulers

Fixes quarkusio#25818

This is part of a coordinated fix across Quarkus and Mutiny where scheduler wrapping would cause Vert.x context propagation not to be done.

Some changes have been adapted from the draft code from @luneo7 in the discussions of:

- quarkusio#26242
- quarkusio#25818

See the matching changes in Mutiny:  smallrye/smallrye-mutiny#955
jponge added a commit to jponge/quarkus that referenced this pull request Jun 21, 2022
…hedulers

Fixes quarkusio#25818

This is part of a coordinated fix across Quarkus and Mutiny where scheduler wrapping would cause Vert.x context propagation not to be done.

Some changes have been adapted from the draft code from @luneo7 in the discussions of:

- quarkusio#26242
- quarkusio#25818

See the matching changes in Mutiny:  smallrye/smallrye-mutiny#955
jponge added a commit to jponge/quarkus that referenced this pull request Jun 22, 2022
…hedulers

Fixes quarkusio#25818

This is part of a coordinated fix across Quarkus and Mutiny where scheduler wrapping would cause Vert.x context propagation not to be done.

Some changes have been adapted from the draft code from @luneo7 in the discussions of:

- quarkusio#26242
- quarkusio#25818

See the matching changes in Mutiny:  smallrye/smallrye-mutiny#955
jponge added a commit to jponge/quarkus that referenced this pull request Jun 22, 2022
…hedulers

Fixes quarkusio#25818

This is part of a coordinated fix across Quarkus and Mutiny where scheduler wrapping would cause Vert.x context propagation not to be done.

Some changes have been adapted from the draft code from @luneo7 in the discussions of:

- quarkusio#26242
- quarkusio#25818

See the matching changes in Mutiny:  smallrye/smallrye-mutiny#955
gsmet pushed a commit to gsmet/quarkus that referenced this pull request Jun 28, 2022
…hedulers

Fixes quarkusio#25818

This is part of a coordinated fix across Quarkus and Mutiny where scheduler wrapping would cause Vert.x context propagation not to be done.

Some changes have been adapted from the draft code from @luneo7 in the discussions of:

- quarkusio#26242
- quarkusio#25818

See the matching changes in Mutiny:  smallrye/smallrye-mutiny#955

(cherry picked from commit 059b7b7)
@jponge jponge modified the milestones: 2.0.0, 2.0.0-milestone1 Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport PR that shall be back-ported bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants